public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rommel G Custodio <sessyargc+u-boot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] mmc: Remove ops from struct mmc and put in mmc_ops
Date: Thu, 27 Feb 2014 04:04:55 +0000 (UTC)	[thread overview]
Message-ID: <loom.20140227T044544-483@post.gmane.org> (raw)
In-Reply-To: 1393437144-27563-1-git-send-email-panto@antoniou-consulting.com

Dear Pantelis Antoniou

Pantelis Antoniou <panto <at> antoniou-consulting.com> writes:

> 
> Remove the in-structure ops and put them in mmc_ops with
> a constant pointer to it.
> 
> This makes the mmc structure smaller as well as conserving
> code space (in theory).

First build is latest master. Second build was with your patch. Compare size 
output.


[local (powerpc-linux-gnuspe)]$ powerpc-linux-gnuspe-size obj-
P5040DS_SPIFLASH_master/u-boot
   text    data     bss     dec     hex filename
 463352   39236  314064  816652   c760c obj-P5040DS_SPIFLASH_master/u-boot


[local (powerpc-linux-gnuspe)]$ powerpc-linux-gnuspe-size obj-
P5040DS_SPIFLASH/u-boot
   text    data     bss     dec     hex filename
 463364   39256  314064  816684   c762c obj-P5040DS_SPIFLASH/u-boot

> 
> All in-tree drivers are converted as well; this is done in a
> single patch in order to not break git bisect.
> 

<snipped>

  reply	other threads:[~2014-02-27  4:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 17:52 [U-Boot] [RFC] mmc: Remove ops from struct mmc and put in mmc_ops Pantelis Antoniou
2014-02-27  4:04 ` Rommel G Custodio [this message]
2014-02-27 13:50   ` Tom Rini
2014-02-27 13:46 ` Tom Rini
2014-03-03 10:04 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20140227T044544-483@post.gmane.org \
    --to=sessyargc+u-boot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox