public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bernhard Nortmann <bernhard.nortmann@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc_write.c: Make mmc_berase do 32bit safe 64bit	math
Date: Fri, 12 Jun 2015 07:32:59 +0000 (UTC)	[thread overview]
Message-ID: <loom.20150612T092540-712@post.gmane.org> (raw)
In-Reply-To: 1434070411-28082-1-git-send-email-trini@konsulko.com

Tom Rini <trini <at> konsulko.com> writes:
> 
> We want to see if the requested start or total block count are
> unaligned.  We discard the whole numbers and only care about the
> remainder.  Update the code to use div_u64_rem here and add a comment.
> 
> ---
>  drivers/mmc/mmc_write.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc_write.c b/drivers/mmc/mmc_write.c
> index 3db9669..7aea7e9 100644

Hi Tom!

I can confirm that this patch solves the CONFIG_SYS_64BIT_LBA compilation
issue with armhf for me (gcc 4.8.3 armv7a-hardfloat-linux-gnueabi, on a
Banana Pi = sun7i/A20).

So I'll add a
Tested-by: Bernhard Nortmann <bernhard.nortmann@web.de>

BTW: There's a small typo you also might want to fix: "The erase range would
be change to " -> "The erase range would be changed to "

Regards, B. Nortmann

  reply	other threads:[~2015-06-12  7:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  0:53 [U-Boot] [PATCH] mmc_write.c: Make mmc_berase do 32bit safe 64bit math Tom Rini
2015-06-12  7:32 ` Bernhard Nortmann [this message]
2015-06-16  9:53 ` [U-Boot] " Hans de Goede
2015-06-18 22:46 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20150612T092540-712@post.gmane.org \
    --to=bernhard.nortmann@web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox