public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Let source cross-reference targets follow symbolic links
Date: Fri, 15 Jul 2011 17:19:35 +0200	[thread overview]
Message-ID: <m239i7po54.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1310721846-7216-1-git-send-email-hkronsto@frequentis.com> (hkronsto@frequentis.com's message of "Fri, 15 Jul 2011 11:24:06 +0200")

Hi Horst,

> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Changes for v2:
>     - Apply this change to all source cross-reference targets

This needs to go below the '---' as it is not part of the git commit
message.

> ---
>  Makefile |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e56fa02..e86a81a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS)
>  TAG_SUBDIRS += $(dir $(__LIBS))
>  TAG_SUBDIRS += include
>  
> +FIND := find -L

I really dislike this approach.  I would never expect a variable $(FIND)
to already include options.  So if you want to go that way then also
introduce FINDFLAGS.

Thanks
  Detlev

-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2011-07-15 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 11:56 [U-Boot] [PATCH] Let target 'cscope' follow symbolic links Horst Kronstorfer
2011-07-15  7:33 ` Detlev Zundel
2011-07-15  8:11   ` KRONSTORFER Horst
2011-07-15  9:24 ` [U-Boot] [PATCH v2] Let source cross-reference targets " hkronsto at frequentis.com
2011-07-15 15:19   ` Detlev Zundel [this message]
2011-07-18 11:21   ` [U-Boot] [PATCH v3] " hkronsto at frequentis.com
2011-07-19 16:32     ` Detlev Zundel
2011-07-28 14:30     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m239i7po54.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox