public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Duplicated string prefix
Date: Thu, 19 May 2011 10:46:01 +0200	[thread overview]
Message-ID: <m24o4rqdrq.fsf@ohwell.denx.de> (raw)
In-Reply-To: <4DD41EE4.3010009@gmail.com> (Gray Remlin's message of "Wed, 18 May 2011 20:32:52 +0100")

Hi Gray,

> The string prefixes "*** ERROR:" and "WARNING:" (or variations thereof) 
> is duplicated numerous times throughout u-boot.
> Replacing with e.g. a 'putserr' function which prepends the string 
> prefix to the unique part of the error message and then displays it may 
> be a worthwhile space saving.

You should be able to tell beforehand how much this could save by
analyzing the strings in a current U-Boot compile, right?  This way one
would know whether it makes sense to embark on that journey.

_If_ we decide to go down that route, I'd suggest using functions
comparable to what Linux offers, e.g. something like pr_err, pr_warning,
etc.

Cheers
  Detlev

-- 
Perfecting oneself is as much unlearning as it is learning. 
                                        -- Edsger Dijkstra 
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

      reply	other threads:[~2011-05-19  8:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 19:32 [U-Boot] [RFC] Duplicated string prefix Gray Remlin
2011-05-19  8:46 ` Detlev Zundel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24o4rqdrq.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox