public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] cmd_nvedit.c: clean up with checkpatch
Date: Wed, 27 Apr 2011 16:44:01 +0200	[thread overview]
Message-ID: <m24o5jah5a.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1303870605-31401-1-git-send-email-macpaul@andestech.com> (Macpaul Lin's message of "Wed, 27 Apr 2011 10:16:45 +0800")

Hi,

> Code clean up of cmd_nvedit.c by using checkpatch.pl.
>
> Signed-off-by: Macpaul Lin <macpaul@andestech.com>

Visual inspection shows only cosmetic changes, so the patch looks good.

For the next time, we should follow the (newly added) clause in our
wiki[1] and have a ommit text like "cosmetic: code cleanup of
cmd_nvedit.c using checkpatch.pl".

As this is very new, I won't insists, so

Acked-by: Detlev Zundel <dzu@denx.de>

Thanks!
  Detlev

-- 
Q: Does that mean we also shouldn't be using IRQF_SAMPLE_RANDOM on
   interrupt [sources]?
A: Yes. The flag needs to be taken out and shot.
                            -- Matt Mackall <1239116251.14392.133.camel@calx>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2011-04-27 14:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  7:02 [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch Macpaul Lin
2011-04-15  8:00 ` Mike Frysinger
2011-04-15  8:25   ` Macpaul Lin
2011-04-15  8:53     ` Mike Frysinger
2011-04-15  8:57       ` Macpaul Lin
2011-04-15 10:09       ` Wolfgang Denk
2011-04-15 10:18         ` Mike Frysinger
2011-04-16  6:18           ` Macpaul Lin
2011-04-16  6:35             ` Albert ARIBAUD
2011-04-16  6:22         ` Albert ARIBAUD
2011-04-16  7:07           ` Graeme Russ
2011-04-16 11:17             ` Macpaul Lin
2011-04-16 12:55               ` Albert ARIBAUD
2011-04-25  8:55               ` [U-Boot] [PATCH v2] " Macpaul Lin
2011-04-27 10:11                 ` Detlev Zundel
2011-04-27 10:53                   ` Macpaul Lin
2011-04-27  2:16               ` [U-Boot] [PATCH v3] " Macpaul Lin
2011-04-27 14:44                 ` Detlev Zundel [this message]
2011-04-27 14:49                   ` Macpaul Lin
2011-04-30 20:27                 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24o5jah5a.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox