From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Wed, 04 Jun 2008 12:45:09 +0200 Subject: [U-Boot-Users] [PATCH 7/8] ppc4xx: Remove superfluous dram_init() call or replace it by initdram() In-Reply-To: <1212433356-27144-7-git-send-email-sr@denx.de> (Stefan Roese's message of "Mon, 2 Jun 2008 21:02:35 +0200") References: <1212433356-27144-1-git-send-email-sr@denx.de> <1212433356-27144-7-git-send-email-sr@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, > Historically the 405 U-Boot port had a dram_init() call in early init > stage. This function was still called from start.S and most of the time > coded in assembler. This is not needed anymore (since a long time) and > boards should implement the common initdram() function in C instead. > > This patch now removed the dram_init() call from start.S and removes the > empty implementations that are scattered through most of the 405 board > ports. Some older board ports really implement this dram_init() though. > These are: > > csb272 > csb472 > ERIC > EXBITGEN > W7OLMC > W7OLMG > > I changed those boards to call this assembler dram_init() function now > from their board specific initdram() instead. This *should* work, but please > test again on those platforms. And it is perhaps a good idea that those > boards use some common 405 SDRAM initialization code from cpu/ppc4xx at > some time. So further patches welcome here. > > Signed-off-by: Stefan Roese I put those maintainers that I could find on CC to inform them. You could have done the same ;) ERIC and W70LMC, W70LMG don't have maintainer entries... Cheers Detlev -- You see, the best way to solve a problem is to rigorously define it in terms of other people's problems, and then run away quickly. -- Roland McGrath -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de