From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Fri, 29 Apr 2011 14:54:58 +0200 Subject: [U-Boot] [PATCH] MX31: change return value of get_cpu_rev In-Reply-To: <4DBAAB9C.7030604@denx.de> (Stefano Babic's message of "Fri, 29 Apr 2011 14:14:20 +0200") References: <1304061193-23544-1-git-send-email-sbabic@denx.de> <4DBAAB9C.7030604@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, [...] >>> @@ -129,7 +129,7 @@ char *get_cpu_rev(void) >>> for (i = 0; i < ARRAY_SIZE(mx31_cpu_type); i++) >>> if (srev == mx31_cpu_type[i].srev) >>> return mx31_cpu_type[i].v; >>> - return "unknown"; >>> + return srev; >> >> Hm, so we drop the "unknown" case and return the srev unchanged. > > Yes, I have changed this behavior. I thought, if the revision is not in > the table, it is better to know which is the value of srev register. I > do not know if it is better to print only an "unknown" or get directly > the value of the register, to check in some documentation which new > version was put on the board. Well, I do not insist on "unknown" - all I want is some way that someone reading the message can tell whether it is a translated or an untranslated value. I.e. adding a second (sensible) output string for no translation is also ok for me. Cheers Detlev -- Man is a fool, and woman, for tolerating him, is a damned fool -- Mark Twain -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de