[U-Boot] [PATCH 2/6] NET: pass source IP address to packet handlers

Luca Ceresoli
2011-05-03T08:54:18Z

Hi Wolfgang,

Wolfgang Denk wrote:

> Dear Luca Ceresoli,
>
> In message<1302796377-3321-3-git-send-email-luca.ceresoli@comelit.it> you wrote:
>> This is needed for the upcoming TFTP server implementation.
>>
>> This also simplifies PingHandler() and fixes rxhand_f documentation.
>>
>> Signed-off-by: Luca Ceresoli<luca.ceresoli@comelit.it>
>> Cc: Wolfgang Denk<wd@denx.de>
> Undone this and previous one as there is a V2 version of this patch.
>
> I wish you would thread yout postings!
I'm sorry for your wasted time, but it's not clear (to me at least...) how
postings should be threaded in the U-Boot ml.

The Wiki says:

> Make sure that your mailer adds or keeps correct
> |"In-reply-to:"| and|"References:"| headers, so threading of
> messages is working and everybody can see that the new message
> refers to some older posting of the same topic.
>
> Uncommented and un-threaded repostings are extremely annoying and
> time-consuming, as we have to try to remember if anything similar has
> been posted before, look up the old threads, and then manually
> compare if anything has been changed, or what.

'correct|"In-reply-to:"| and|"References:"|' can have many interpretations.

On the ML I see varying ones, and I even see submissions with NO THREADING
AT ALL: the first submit is in a thread, v2 starts a new thread, v3 yet
another one etc.

MY humble interpretation of the Wiki wording is this:

- [PATCH 0/2]
|
+-> [PATCH 1/2]
+-> [PATCH 2/2]
| +-> Re: [PATCH 2/2] reviewers comments to patch 2/2
| +-> Re: [PATCH 2/2] more reviewers comments to patch 2/2
|
+-> Re: [PATCH 0/2] reviewers comments to the patchset (0/2)
| +-> Re: [PATCH 0/2] discussion...
|
+-> [PATCH v2 0/2] resubmit (In-Reply-To: the first submit)
|
+-> [PATCH v2 1/2]
+-> [PATCH v2 2/2]
| ... more discussion - not shown...
|
+-> [PATCH v3 0/2] resubmit (In-Reply-To: the first submit)
|
+-> [PATCH v3 1/2]
+-> [PATCH v3 2/2]

What's wrong with this?
Please state in absolutely unambiguous detail what the correct threading is,
and please docuemnt it in the wiki for everybody.

My postings look correctly threaded according to the above interpretation,
as you can see for example on the Gmane threaded interface.

Luca