[U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

Detlev Zundel
2011-04-20T08:17:24Z

Hi Luca,

> Hi,
>
> just a few e-mails ago along this thread Albert Aribaud wrote:
>
>> My opinion is that you should make sure that at least the code you touch
>> is checkpatch-clean, so yes, you should fix that; but there is no need
>> to submit 'checkpatch-compliance' patches. Just fix the line here so
>> that checkpatch does not complain.
>
>
> So I proceeded along that way.
>
> Now Detlev Zundel wrote:
>> ...
>> Hm, I see. Still, can we have one commit (with "cosmetic" in the
>> changelog) that silences checkpatch but does not have any functional
>> changes? We really try hard to separate cosmetic from functional
>> changes. This makes reviewing (and debugging) so much easier.
>
> While I appreciate the careful review of my patches, I cannot hide
> that it is discouraging for new contributors to be requested for
> contradictory modifications.

Sorry for that, but it is only that we start using checkpatch more
aggressively, that such problems turn up which we did not yet agree on
how to solve.

> There should be one precise policy, and that should be clearly documented.

I fully agree.

> http://www.denx.de/wiki/U-Boot/CodingStyle is the place where I would
> expect to find it.

I'll start a new thread to discuss this. Hopefully we then come up with
a policy to stick into that wiki page.

Thanks for bearing with me
Detlev

--
In God we trust. All others we monitor
-- NSA motto
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de