[U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

Detlev Zundel
2011-04-19T16:28:04Z

Hi Luca,

[...]

>> Whitespace fix.
>
> checkpatch again.

Hm, I see. Still, can we have one commit (with "cosmetic" in the
changelog) that silences checkpatch but does not have any functional
changes? We really try hard to separate cosmetic from functional
changes. This makes reviewing (and debugging) so much easier.

This is the second time that I personally encounter that problem and I
still don't see an automated way to take care of this. This simply is
the result that checkpatch will flag only new errors when there are no
_old_ ones. The reality of course looks different:

[dzu at pollux u-boot-testing (master)]$ ../linux/scripts/checkpatch.pl -f net/net.c

[...]

total: 76 errors, 193 warnings, 1934 lines checked

net/net.c has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

If we strictly do require checkpatch cleanliness, maybe we should start
cleaning up the code base as is first with only cosmetic changes. Do I
see volunteers? ;)

Cheers
Detlev

--
Life is complex. It has real and imaginary components.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de