public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] TI: DaVinci DA850 EVM: support passing device speed grade information to kernel
Date: Wed, 18 Aug 2010 10:08:45 +0200	[thread overview]
Message-ID: <m28w44gx6a.fsf@ohwell.denx.de> (raw)
In-Reply-To: <20100817184618.3C67C157D71@gemini.denx.de> (Wolfgang Denk's message of "Tue, 17 Aug 2010 20:46:18 +0200")

Hi Wolfgang,

> Dear Detlev Zundel,
>
> In message <m2hbitgthb.fsf@ohwell.denx.de> you wrote:
>> 
>> > You mean replace "maxspeed" by "cpuclk"? As I have noted a number of times
>> > before, we are not passing the cpu clock speed here. That information kernel
>> > directly reads from system registers. No need to pass it from U-Boot. The
>> > example you are giving is not the right comparison.
>> 
>> Ok, then currently I would vote for "cpumaxspeed_mhz".
>
> Even though its pretty descriptive - for the sake of consistency I
> recommend to omit the "_mhz" part. 

I know that I will mutter a not so nice remark every time I use the
variable and am forced to look up the documentation for a single setenv
command instead of typing 4 more characters.

I still remember the days of "clocks_in_mhz" and the waste of time it
produced - maybe this is why I continue to raise this concern.

> Also, I feel that "clock" would be more appropriate than "speed". And
> we should consider that we already use "cpuclk" for very similar
> purposes in U-Boot.
>
> Can we agree on "cpumaxclk" ?

If nobody else shares my concerncs this sounds good.

Cheers
  Detlev

-- 
#!/usr/bin/perl
$c="print\"\#\!\/usr\/bin\/perl\
\\\$c\=\\\"\"\.quotemeta\(\$c\)\.\"\\\"\;\\n\$c;\"";
print"#!/usr/bin/perl\n\$c=\"".quotemeta($c)."\";\n$c;";
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2010-08-18  8:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12  5:42 [U-Boot] [PATCH v2] TI: DaVinci DA850 EVM: support passing device speed grade information to kernel Sekhar Nori
2010-08-12 12:53 ` Detlev Zundel
2010-08-12 15:38   ` Nori, Sekhar
2010-08-13  8:30     ` Detlev Zundel
2010-08-13  9:22       ` Nori, Sekhar
2010-08-13 10:39         ` Detlev Zundel
2010-08-16 11:23           ` Nori, Sekhar
2010-08-17 12:12             ` Detlev Zundel
2010-08-17 13:10               ` Nori, Sekhar
2010-08-17 15:16                 ` Detlev Zundel
2010-08-17 18:46                   ` Wolfgang Denk
2010-08-18  8:08                     ` Detlev Zundel [this message]
2010-08-18 10:49                       ` Wolfgang Denk
2010-08-18 11:33                         ` Detlev Zundel
2010-08-18  9:00                   ` Nori, Sekhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28w44gx6a.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox