From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Mon, 11 Jan 2010 17:07:33 +0100 Subject: [U-Boot] [PATCH 2/9] MX51: Add initial support for the Freescale MX51 In-Reply-To: <4B4B4AA9.9040401@denx.de> (Stefano Babic's message of "Mon, 11 Jan 2010 16:58:33 +0100") References: <1263212760-27272-1-git-send-email-sbabic@denx.de> <1263212760-27272-2-git-send-email-sbabic@denx.de> <1263212760-27272-3-git-send-email-sbabic@denx.de> <4B4B4AA9.9040401@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, > Detlev Zundel wrote: >> Hi Stefano, >> > > Hi Detlev, > >>> --- /dev/null >>> +++ b/cpu/arm_cortexa8/mx51/iomux.c >>> @@ -0,0 +1,205 @@ >>> +/* >>> + * Copyright 2009 Freescale Semiconductor, Inc. All Rights Reserved. >>> + */ >>> + >>> +/* >>> + * The code contained herein is licensed under the GNU General Public >>> + * License. You may obtain a copy of the GNU General Public License >>> + * Version 2 or later at the following locations: >>> + * >>> + * http://www.opensource.org/licenses/gpl-license.html >>> + * http://www.gnu.org/copyleft/gpl.html >>> + */ >> >> This header is not good enough - it is not clear what actual version of >> the GPL the code is licensed under. Please replace this with a >> "standard" header. > > I agree, but the copyright was set by Freescale and Fred in the first > review said, he was not the original author of the code. I think I am > not allowed to change this part even if I will not change the copyright > statement. Of course, if I can, I will replace it with a standard header. Well, I presume that we all agree the text wants to be read to mean "GPLv2 or later", although it does not state that clearly enough. So all I ask for is to make this more explicit - it is _not_ a change of the licensing at all. Thanks Detlev -- The fact is, volatile on data structures is a bug. It's a wart in the C language. It shouldn't be used. -- Linus Torvalds -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de