From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/inka4x0: Remove left-over ide reset code.
Date: Wed, 13 May 2009 11:30:14 +0200 [thread overview]
Message-ID: <m28wl1ic49.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1241532246-9399-1-git-send-email-dzu@denx.de> (Detlev Zundel's message of "Tue, 5 May 2009 16:04:06 +0200")
Hi Grant,
realizing that I forgot to CC you on the original mail[1], I now formally
ask you to pull the patch into your repo as it fixes a real bug.
Thanks
Detlev
[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/59148
> The pin which was used in preliminary versions of the board for ide
> reset is really connected to the rtc clock.
>
> Signed-off-by: Detlev Zundel <dzu@denx.de>
> ---
> board/inka4x0/inka4x0.c | 33 ---------------------------------
> include/configs/inka4x0.h | 1 -
> 2 files changed, 0 insertions(+), 34 deletions(-)
>
> diff --git a/board/inka4x0/inka4x0.c b/board/inka4x0/inka4x0.c
> index 7428b92..c645b05 100644
> --- a/board/inka4x0/inka4x0.c
> +++ b/board/inka4x0/inka4x0.c
> @@ -274,36 +274,3 @@ void pci_init_board(void)
> pci_mpc5xxx_init(&hose);
> }
> #endif
> -
> -#if defined(CONFIG_CMD_IDE) && defined(CONFIG_IDE_RESET)
> -
> -void init_ide_reset (void)
> -{
> - volatile struct mpc5xxx_wu_gpio *wu_gpio =
> - (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO;
> -
> - debug ("init_ide_reset\n");
> -
> - /* Configure PSC1_4 as GPIO output for ATA reset */
> - setbits_8(&wu_gpio->enable, MPC5XXX_GPIO_WKUP_PSC1_4);
> - setbits_8(&wu_gpio->ddr, MPC5XXX_GPIO_WKUP_PSC1_4);
> - /* Deassert reset */
> - setbits_8(&wu_gpio->dvo, MPC5XXX_GPIO_WKUP_PSC1_4);
> -}
> -
> -void ide_set_reset (int idereset)
> -{
> - volatile struct mpc5xxx_wu_gpio *wu_gpio =
> - (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO;
> -
> - debug ("ide_reset(%d)\n", idereset);
> -
> - if (idereset) {
> - clrbits_8(&wu_gpio->dvo, MPC5XXX_GPIO_WKUP_PSC1_4);
> - /* Make a delay. MPC5200 spec says 25 usec min */
> - udelay(500000);
> - } else {
> - setbits_8(&wu_gpio->dvo, MPC5XXX_GPIO_WKUP_PSC1_4);
> - }
> -}
> -#endif
> diff --git a/include/configs/inka4x0.h b/include/configs/inka4x0.h
> index 5f06b09..46606ca 100644
> --- a/include/configs/inka4x0.h
> +++ b/include/configs/inka4x0.h
> @@ -418,7 +418,6 @@ static inline void tws_data_config_output(unsigned output)
> #undef CONFIG_IDE_8xx_DIRECT /* Direct IDE not supported */
> #undef CONFIG_IDE_LED /* LED for ide not supported */
>
> -#define CONFIG_IDE_RESET /* reset for ide supported */
> #define CONFIG_IDE_PREINIT
>
> #define CONFIG_SYS_IDE_MAXBUS 1 /* max. 1 IDE bus */
--
Old mathematicians never die; they just lose some of their functions.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2009-05-13 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 14:04 [U-Boot] [PATCH] powerpc/inka4x0: Remove left-over ide reset code Detlev Zundel
2009-05-13 9:30 ` Detlev Zundel [this message]
2009-05-13 13:49 ` Grant Likely
2009-05-13 15:26 ` Detlev Zundel
2009-05-15 19:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28wl1ic49.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox