From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH: Update U-Boot EXT2 Filesystem to support dynamic inode size and optimize ext2 read function to fasten read speed!
Date: Fri, 01 Aug 2008 11:44:15 +0200 [thread overview]
Message-ID: <m2abfxax3k.fsf@ohwell.denx.de> (raw)
In-Reply-To: <008501c8f1e8$042046f0$30065e0a@SHZ.ST.COM> (Ryan CHEN's message of "Wed, 30 Jul 2008 10:00:18 +0800")
Hi Ryan,
> I have modified my patch according to your suggestion. The only question is
> that use debug() because I found all debug print msg lines are written as :
> #ifdef DEBUG
> printf(......);
> #endif
> Are you sure I need change my debug print to debug()?
Yes, please. We introduced the macro especially for this to make the
code more readable.
If you find other instances of the macro not being used, feel free to
send a patch changing it ;)
Cheers
Detlev
--
Multiple exclamation marks, the sure sign of an insane mind.
-- Terry Pratchett
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2008-08-01 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 8:48 [U-Boot-Users] PATCH: Update U-Boot EXT2 Filesystem to support dynamic inode size and optimize ext2 read function to fasten read speed! Ryan CHEN
2008-07-29 20:10 ` Scott Wood
2008-07-30 1:37 ` Ryan CHEN
2008-07-29 23:16 ` Wolfgang Denk
2008-07-30 2:00 ` Ryan CHEN
2008-08-01 9:44 ` Detlev Zundel [this message]
2008-08-18 21:58 ` [U-Boot] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2abfxax3k.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox