From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] README: Clarify difference of CONFIG_WATCHDOG and CONFIG_HW_WATCHDOG
Date: Fri, 29 Apr 2011 13:06:56 +0200 [thread overview]
Message-ID: <m2bozp71v3.fsf@ohwell.denx.de> (raw)
In-Reply-To: <BANLkTi=04WpEovHoWJCfUjUyLvHsG3fJYg@mail.gmail.com> (Mike Frysinger's message of "Wed, 27 Apr 2011 12:27:12 -0400")
Hi Mike,
> On Wed, Apr 27, 2011 at 11:25, Detlev Zundel wrote:
>> Now that we have the documentation, the code should be changed to reflect
>> it ;)
>>
>> Asd far as I can see, these are the places where HW_WATCHDOG is used
>> instead of WATCHDOG:
>
> the trouble is that watchdog.h doesnt seem to match, nor does the
> name. "hardware" means to me "hardware" as in "the cpu hardware".
Yes, I understand that the situation is not 100% ideal, but I do not
share your pessimism. Currently we should straighten out the
inconsistencies present in the code and then subsequently we can think
about aligning it with what we agree on to be a good name for.
>
> #ifdef CONFIG_HW_WATCHDOG
> ...
> #else
> /*
> * Maybe a software watchdog?
> */
> ...
> #endif
>
> i dont see how a watchdog in the SoC could be a "software" watchdog or
> a "non-hardware" watchdog.
True, we should align the comments in here also - I'll se if I can come
up with something sensible.
> the watchdog system is a legacy mess, so probably be easier to just
> gut the whole thing.
A agree that the naming is not ideal, but this isn't a good enough
argument for removing it. Apart from that, this feature is used in many
commercial systems...
Cheers
Detlev
--
config LGUEST
If unsure, say N. If curious, say M. If masochistic, say Y.
-- linux/drivers/lguest/Kconfig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-04-29 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 15:25 [U-Boot] [PATCH] README: Clarify difference of CONFIG_WATCHDOG and CONFIG_HW_WATCHDOG Detlev Zundel
2011-04-27 16:27 ` Mike Frysinger
2011-04-29 11:06 ` Detlev Zundel [this message]
2011-04-30 0:17 ` Mike Frysinger
2011-05-12 21:26 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bozp71v3.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox