[U-Boot-Users] [PATCH V2] ARM: Add support for Lyrtech SFF-SDR board (ARM926EJS)

Wolfgang Denk
2008-05-22T15:30:15Z

In message <1211469582-3656-1-git-send-email-hugo.villeneuve@lyrtech.com> you wrote:
> ARM: This patch adds support for the Lyrtech SFF-SDR
> board, based on the TI DaVinci architecture (ARM926EJS).
>
> Signed-off-by: Hugo Villeneuve <hugo.villeneuve@lyrtech.com>
> Signed-off-by: Philip Balister <philip@balister.org>

There are a lot of new files, and you sign these off, but I don't see
your copyright notice in either of these. How comes? Didn't you modify
this code?

...
> diff --git a/include/configs/davinci_sffsdr.h b/include/configs/davinci_sffsdr.h
> new file mode 100644
> index 0000000..b62ea74
...
> +#define CONFIG_BOOTCOMMAND \
> + "setenv setboot setenv bootargs \\$(bootargs);run setboot"

Do not use the old "$(...)" syntax any more, it is deprecated. Please
use "${...}" instead.

Also, this statement is nonsense, as you don't do anything there that
has any effect.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a group that keeps the minutes and loses hours.
-- Milton Berle