From: Kevin Hilman <khilman@baylibre.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mmc: Add Amlogic Meson driver
Date: Fri, 13 May 2016 18:07:52 +0200 [thread overview]
Message-ID: <m2d1oq2b6v.fsf@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2Y6zoYfD88-tSCS78=zON-nr8FbU1nOkoDQz3a1FnTy5Q@mail.gmail.com> (Carlo Caione's message of "Fri, 13 May 2016 15:53:35 +0200")
Carlo Caione <carlo@caione.org> writes:
> On Fri, May 13, 2016 at 3:46 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Carlo Caione <carlo@caione.org> writes:
>>
>>> From: Carlo Caione <carlo@endlessm.com>
>>>
>>> This is a port / rewrite of the Amlogic driver shipped whithin the
>>> Amlogic SDK for the Meson GXBaby (S905) SoC.
>>>
>>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>>
>> [...]
>>
>>> +static const struct udevice_id meson_mmc_match[] = {
>>> + { .compatible = "amlogic,meson-mmc" },
>>> + { /* sentinel */ }
>>
>> IIUC, this controller is different between meson8* and gxbb. If that's
>> the case, this compatible should probably be more specific.
>
> Yes, this is a point I raised also on lkml when I submitted the MMC
> driver for the Meson8b.
> Since the registers mapping is different I assume that this is the
> case. Just to be sure, given that you are the only one with a
> datasheet for the GXBB, can you confirm that?
I took a quick look and just compared the register layouts between s805
and s905 and indeed they are quite different.
Kevin
next prev parent reply other threads:[~2016-05-13 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 12:41 [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller Carlo Caione
2016-05-12 12:41 ` [U-Boot] [PATCH 1/2] mmc: Add Amlogic Meson driver Carlo Caione
2016-05-13 13:46 ` Kevin Hilman
2016-05-13 13:53 ` Carlo Caione
2016-05-13 16:07 ` Kevin Hilman [this message]
2016-08-07 15:49 ` Andreas Färber
2016-08-04 6:48 ` [U-Boot] [U-Boot,1/2] " Jaehoon Chung
2016-05-12 12:41 ` [U-Boot] [PATCH 2/2] arm: amlogic: Enable MMC driver on Odroid-C2 Carlo Caione
2016-05-20 4:51 ` [U-Boot] [PATCH 0/2] Add support for Amlogic Meson MMC controller Robert Gadsdon
2016-05-20 6:27 ` Carlo Caione
2016-05-20 8:07 ` Carlo Caione
2016-05-20 18:58 ` Robert Gadsdon
2016-05-20 19:34 ` Carlo Caione
2016-05-21 2:28 ` Robert Gadsdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d1oq2b6v.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox