public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] Revert "i.MX28: Enable additional DRAM address bits"
Date: Thu, 03 May 2012 10:11:31 +0200	[thread overview]
Message-ID: <m2d36lsmz0.fsf@lamuella.denx.de> (raw)
In-Reply-To: <1335996878-2264-1-git-send-email-marex@denx.de> (Marek Vasut's message of "Thu, 3 May 2012 00:14:36 +0200")

Hi Marek,

> This reverts commit 69d26d09de1cb93e0a09ca71d9f0d41a66f0756a.
>
> Apparently, this commit got mainline only because of OOT port and causes
> breakage on board that is mainline. Revert.

To be honest, I don't understand what this patch or what the original
patch did, nor through what OOT port this hit mainline and what breakage
it causes on other boards.

So also I can read the sentence, I cannot make heads and tails of it.
Can you please write commit messages that people like me can make some
sense from?  I.e. answering the following questions would help me

- What does the original commit do? (its too late to change the original
  commit) 
- Why was the change made in the first place and for what OOT port?
- What breakage is caused on what boards?
- Why can we revert the change without any problems?

Thanks
  Detlev

-- 
#!/usr/bin/perl -l
print ((1 x shift) !~ /^(11+?)\1+$/ ? "prime" : "not prime");
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  parent reply	other threads:[~2012-05-03  8:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 22:14 [U-Boot] [PATCH 1/3] Revert "i.MX28: Enable additional DRAM address bits" Marek Vasut
2012-05-02 22:14 ` [U-Boot] [PATCH 2/3] M28: Scan only first 512 MB of DRAM to avoid memory wraparound Marek Vasut
2012-05-02 22:14 ` [U-Boot] [PATCH 3/3] i.MX28: Increase the delay after DRAM init Marek Vasut
2012-05-02 22:55   ` Fabio Estevam
2012-05-02 23:27     ` Marek Vasut
2012-05-03  8:12       ` Detlev Zundel
2012-05-03 13:31         ` Marek Vasut
2012-05-03 14:27           ` Detlev Zundel
2012-05-03 14:39             ` Marek Vasut
2012-05-03 15:34             ` Marek Vasut
2012-05-04  9:16               ` Detlev Zundel
2012-05-03  8:11 ` Detlev Zundel [this message]
2012-05-03 13:36   ` [U-Boot] [PATCH 1/3] Revert "i.MX28: Enable additional DRAM address bits" Marek Vasut
2012-05-03 14:30     ` Detlev Zundel
2012-05-03 14:41       ` Marek Vasut
2012-05-04  9:15         ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d36lsmz0.fsf@lamuella.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox