From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec
Date: Wed, 06 Apr 2011 15:01:06 +0200 [thread overview]
Message-ID: <m2d3kzo7ot.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1302040794-19837-6-git-send-email-afleming@freescale.com> (Andy Fleming's message of "Tue, 5 Apr 2011 16:59:53 -0500")
Hi Andy,
> The tsec driver had a bunch of PHY drivers already written. This
> converts them all into PHY Lib drivers, and serves as the first
> set of PHY drivers for PHY Lib.
>
> While doing that, cleaned up a number of magic numbers (though
> not all of them, as PHY vendors like to keep their numbers as
> magical as possible). Also, noticed that almost all of the
> vitesse/cicada PHYs had the same config/parse/startup functions,
> so those have been collapsed into one.
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> ---
> * Added teranetics_init() to init function
> * Sorted init functions in phy_init and in phy.h
> * Sorted PHYs in drivers/net/phy/Makefile
> * GPL v2+ on all new files
> * Left the 500ms delay after autonegotiation for PHY drivers that had it,
> as I don't want to break the driver-specific functionality. I suspect that
> either we've already fixed the bug this was really working around, or we
> will need a bug fix in the generic code. Either way, this code doesn't
> change the previous behavior, and can always be fixed at a later date,
> when one of us has time to actually test it out.
> * Added many constants and consolidated the vitesse functions
Thanks for the changes, especially for the tedious constants stuff. This
looks really good now.
Acked-by: Detlev Zundel <dzu@denx.de>
Cheers
Detlev
--
These days, even the most pure and abstract mathematics is in danger
to be applied.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-04-06 13:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 21:59 [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 1/6] tsec: use IO accessors for IO accesses Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 2/6] tsec: arrange the code to avoid useless function declaration Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 3/6] Remove instances of phy_read/write Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 6/6] tsec: Convert tsec to use PHY Lib Andy Fleming
2011-04-06 13:02 ` Detlev Zundel
2011-04-06 13:01 ` Detlev Zundel [this message]
2011-04-06 22:50 ` [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec Mike Frysinger
2011-04-06 12:56 ` [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot Detlev Zundel
2011-04-06 23:09 ` Mike Frysinger
2011-04-07 14:16 ` Andy Fleming
2011-04-07 15:01 ` Wolfgang Denk
2011-04-07 19:37 ` Mike Frysinger
2011-04-07 4:43 ` Wolfgang Denk
2011-04-07 4:47 ` Mike Frysinger
2011-04-07 7:12 ` Wolfgang Denk
2011-04-07 5:19 ` Wolfgang Denk
2011-04-06 12:32 ` [U-Boot] [PATCH v2 3/6] Remove instances of phy_read/write Detlev Zundel
2011-04-06 12:31 ` [U-Boot] [PATCH v2 2/6] tsec: arrange the code to avoid useless function declaration Detlev Zundel
2011-04-06 12:29 ` [U-Boot] [PATCH v2 1/6] tsec: use IO accessors for IO accesses Detlev Zundel
2011-04-06 12:32 ` Kumar Gala
2011-04-06 12:07 ` [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure Detlev Zundel
2011-04-07 14:13 ` Andy Fleming
2011-04-07 19:43 ` Mike Frysinger
2011-04-08 11:44 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d3kzo7ot.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox