From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Wed, 06 Apr 2011 15:01:06 +0200 Subject: [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec In-Reply-To: <1302040794-19837-6-git-send-email-afleming@freescale.com> (Andy Fleming's message of "Tue, 5 Apr 2011 16:59:53 -0500") References: <1302040794-19837-1-git-send-email-afleming@freescale.com> <1302040794-19837-2-git-send-email-afleming@freescale.com> <1302040794-19837-3-git-send-email-afleming@freescale.com> <1302040794-19837-4-git-send-email-afleming@freescale.com> <1302040794-19837-5-git-send-email-afleming@freescale.com> <1302040794-19837-6-git-send-email-afleming@freescale.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy, > The tsec driver had a bunch of PHY drivers already written. This > converts them all into PHY Lib drivers, and serves as the first > set of PHY drivers for PHY Lib. > > While doing that, cleaned up a number of magic numbers (though > not all of them, as PHY vendors like to keep their numbers as > magical as possible). Also, noticed that almost all of the > vitesse/cicada PHYs had the same config/parse/startup functions, > so those have been collapsed into one. > > Signed-off-by: Andy Fleming > --- > * Added teranetics_init() to init function > * Sorted init functions in phy_init and in phy.h > * Sorted PHYs in drivers/net/phy/Makefile > * GPL v2+ on all new files > * Left the 500ms delay after autonegotiation for PHY drivers that had it, > as I don't want to break the driver-specific functionality. I suspect that > either we've already fixed the bug this was really working around, or we > will need a bug fix in the generic code. Either way, this code doesn't > change the previous behavior, and can always be fixed at a later date, > when one of us has time to actually test it out. > * Added many constants and consolidated the vitesse functions Thanks for the changes, especially for the tedious constants stuff. This looks really good now. Acked-by: Detlev Zundel Cheers Detlev -- These days, even the most pure and abstract mathematics is in danger to be applied. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de