[U-Boot] [PATCH] inka4x0: Add hardware diagnosis and RTC in configuration.

[Detlev Zundel <dzu@denx.de>]

Hi Wolfgang,

> Dear Detlev Zundel,
>
> In message <m23ad2rmh2.fsf@ohwell.denx.de> you wrote:
>> 
>> >> @@ -235,6 +238,23 @@ int misc_init_f (void)
>> >>  	*(vu_long *) MPC5XXX_WU_GPIO_ENABLE |= GPIO_PSC3_9;
>> >>  	*(vu_long *) MPC5XXX_WU_GPIO_DIR    |= GPIO_PSC3_9;
>> >>  	*(vu_long *) MPC5XXX_WU_GPIO_DATA_O   |= GPIO_PSC3_9;
>> >
>> > You don't want to fix the missing accessor functions here, do you? ;-)
>> 
>> Oh I do - actually, I did - please check my later posting "inka4x0: Use
>> proper accessor macros for memory mapped registers."
>
>>From the reviewing point of view it would have been easier if that
> other patch would have come earlier in the sequence. As is, it is
> really difficult to see if the lines above are included in your other
> patch, or if they might have been missed. Keep in mind that reviewing
> is a sequential process...

I know.  Software development is *also* a sequential process.  It was of
course only by the time that I had introduced the new stuff that I saw
what else needs to be fixed.  So the order does indeed reflect my
work-flow.  I honestly did not even think about re-ordering these
patches because of your considerations.  Is it written somewhere that I
have to fix all existing problems first before I get to add new stuff?
;)

> But OK, from the end result it makes no difference.

Well, if one uses a threaded news reader, one might have seen the
summaries of all patches before actually diving in...

Cheers
  Detlev

-- 
Lotus Notes (GUI):   Run away from it.
                           -- linux/Documentation/email-clients.txt
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de