From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da8xx: add support for multiple PLL controllers
Date: Fri, 29 Jul 2011 10:41:41 +0200 [thread overview]
Message-ID: <m2ei197a2i.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1311870338-18950-14-git-send-email-nagabhushana.netagunte@ti.com> (nagabhushana netagunte's message of "Thu, 28 Jul 2011 21:55:38 +0530")
Hi,
[...]
> - pre_div = (readl(&davinci_pllc_regs->prediv) &
> - DAVINCI_PLLC_DIV_MASK) + 1;
> - pllm = readl(&davinci_pllc_regs->pllm) + 1;
> + pre_div = (REG(pll_base + PLLC_PREDIV) & 0xff) + 1;
> + pllm = REG(pll_base + PLLC_PLLM) + 1;
Nack - do not change "common" accessors into local macros. We should
really strive to have a common base here. See also
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104428
Cheers
Detlev
--
He thinks he's really smooth, but he's only C^1.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-07-29 8:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 16:25 [U-Boot] [PATCH] da850: add NOR boot mode support nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: add cache management support in config file nagabhushana.netagunte at ti.com
2011-07-29 8:26 ` Detlev Zundel
2011-08-01 9:44 ` Netagunte, Nagabhushana
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: add provision to use RMII for EMAC nagabhushana.netagunte at ti.com
2011-07-29 8:31 ` Detlev Zundel
2011-08-01 9:46 ` Netagunte, Nagabhushana
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: add support for Spectrum Digital AM18xx EVM nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: add support to read mac address from spi flash nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: add support to wake up DSP during board init nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: fix the channel number for EMAC teardown init nagabhushana.netagunte at ti.com
2011-07-28 18:42 ` Wolfgang Denk
2011-07-29 8:03 ` Netagunte, Nagabhushana
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: modifications for Logic PD Rev.3 AM18xx EVM nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: modify default bootargs and bootcmd nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: modify the U-Boot prompt string nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: pass board revision info to kernel nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: print DDR frequency from u-boot nagabhushana.netagunte at ti.com
2011-07-28 16:25 ` [U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM nagabhushana.netagunte at ti.com
2011-07-28 18:31 ` Mike Frysinger
2011-07-29 18:32 ` Mike Frysinger
2011-08-01 9:50 ` Netagunte, Nagabhushana
2011-08-01 9:38 ` Netagunte, Nagabhushana
2011-07-28 16:25 ` [U-Boot] [PATCH] da8xx: add support for multiple PLL controllers nagabhushana.netagunte at ti.com
2011-07-29 8:41 ` Detlev Zundel [this message]
2011-08-01 9:47 ` Netagunte, Nagabhushana
2011-07-29 8:24 ` [U-Boot] [PATCH] da850: add NOR boot mode support Detlev Zundel
2011-08-01 9:42 ` Netagunte, Nagabhushana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ei197a2i.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox