public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific
Date: Thu, 16 Sep 2010 15:00:05 +0200	[thread overview]
Message-ID: <m2eictzvvu.fsf@ohwell.denx.de> (raw)
In-Reply-To: <201009161418.54408.sr@denx.de> (Stefan Roese's message of "Thu,  16 Sep 2010 14:18:54 +0200")

Hi Stefan,

> Ups. No, I totally missed this. Thanks for spotting. Will fix soon.

Ok.

> Please note that I plan to stay with this "asm/ppc4xx-gpio.h" name instead of 
> "asm/gpio.h", since there are many other PowerPC variants out there.

I have to admit that I don't like this.

Hm, while you are doing something here, why not follow the Blackfin
example which I like a lot and move towards the Linux gpio interface
(see end of ./arch/blackfin/include/asm/gpio.h).  It will be just lovely
to only generically request a gpio in common driver code.

Going down this route, code using gpios will only include "asm/gpio.h"
and use the generic functions.  Doesn't that sound like a worthwhile
target? ;)

Cheers
  Detlev

-- 
Infolge sklavischer "Kategoritis"  werden die wissenschaftlichen unlogischen
und - wie wir sehen werden -  oft sinnlosen Fragen wie "Wo wohnst du?", "Was
bist du?", "Welche Religion?", "Welche Rasse?", "Welche Nationalit?t?" alle-
samt heute f?r logische Fragen gehalten.       -- Richard Buckminster Fuller
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2010-09-16 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13  8:34 [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific Stefan Roese
2010-09-16 12:05 ` Detlev Zundel
2010-09-16 12:18   ` Stefan Roese
2010-09-16 13:00     ` Detlev Zundel [this message]
2010-09-16 13:47       ` Stefan Roese
2010-09-22 20:58         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2eictzvvu.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox