From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Fri, 26 Mar 2010 11:09:50 +0100 Subject: [U-Boot] What's wrong with this code? In-Reply-To: <189691269597507@webmail102.yandex.ru> (Dennis Semakin's message of "Fri, 26 Mar 2010 12:58:27 +0300") References: <98831269592801@webmail103.yandex.ru> <189691269597507@webmail102.yandex.ru> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dennis, > Hi >> >> Why don't you wrap this change into a patch and post it here[1] on the >> mailing list. If there are reasons not to merge it, the respective >> people will speak up. > > Because it's not my patch. I didn't write it. I did only copy and paste. That's not a big problem. Depending on how correct you want to be, you could either use "git commit --author " to commit tha change into your tree and then use git-send-email to post the patch here. The git toolchain will correctly keep the authors name even if you post the patches. Note that patches regularly get (re-)posted by people not being the original author. As long as it is correct from a copyright point of view, this is not a problem. On such a small change however, you may also simply put a short "code originally by ..." in the commit message. The _relevant_ part is that people here need a patch to do a proper review of the change you propose. Cheers Detlev -- You live and learn -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de