From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Thu, 20 Oct 2011 11:25:25 +0200 Subject: [U-Boot] [STATUS] "Quality" of patches / testing. In-Reply-To: <20111018062310.61320140797D@gemini.denx.de> (Wolfgang Denk's message of "Tue, 18 Oct 2011 08:23:10 +0200") References: <20111018062310.61320140797D@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, [...] > Note # 3 at http://www.denx.de/wiki/U-Boot/Patches says: > > Before sending the patch, you must run the MAKEALL script on > your patched source tree and make sure that no errors or > warnings are reported for any of the boards. Well, at least > not any more warnings than without your patch. > > It is strongly recommended to verify that out-of-tree building > (with "-O" make option resp. "BUILD_DIR" environment variable) > is still working. For example, run: > > $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL > > Why is nobody doing this? I'd like to raise awareness looking at the root of the problems, not how to fix the fallout. Why is it that we regularly have cases where ("local") U-Boot changes break ("distant") board configurations? Isn't this a sign that our code base isn't as orhtogonal as it should be? Is such an orthogonality not possible for us? Has anyone got a good explanation why it is this way - and even better ideas on how to improve this? Thanks Detlev -- I think that level of generalization is too abstract for useful thinking. -- Richard Stallman in -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de