From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: Consolidate bootcount_{store|load} for PowerPC
Date: Tue, 27 Apr 2010 16:01:11 +0200 [thread overview]
Message-ID: <m2fx2hngew.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1272292133-1843-1-git-send-email-sr@denx.de> (Stefan Roese's message of "Mon, 26 Apr 2010 16:28:53 +0200")
Hi Stefan,
> This patch consolidates bootcount_{store|load} for PowerPC by
> implementing a common version in arch/powerpc/lib/bootcount.c. This
> code is now used by all PowerPC variants that currently have these
> functions implemented.
>
> The functions now use the proper IO-accessor functions to read/write the
> values.
>
> This code also supports two different bootcount versions:
>
> a) Use 2 seperate words (2 * 32bit) to store the bootcounter
> b) Use only 1 word (2* 16bit) to store the bootcounter
>
> Version b) was already used by MPC5xxx.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Michael Zaidman <michael.zaidman@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> Cc: Anatolij Gustschin <agust@denx.de>
Cool, thanks!
I have only a cosmetic suggestion - can we rename the option
CONFIG_SYS_BOOTCOUNT_USE_32BIT to CONFIG_SYS_BOOTCOUNT_SINGLEWORD?
According to your documentation this would describe the situation
somewhat closer.
Apart from that:
Acked-by: Detlev Zundel <dzu@denx.de>
Cheers
Detlev
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2010-04-27 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 14:28 [U-Boot] [PATCH] powerpc: Consolidate bootcount_{store|load} for PowerPC Stefan Roese
2010-04-27 14:01 ` Detlev Zundel [this message]
2010-04-27 14:11 ` Stefan Roese
2010-04-27 15:56 ` Michael Zaidman
2010-04-28 7:14 ` Stefan Roese
2010-04-28 8:06 ` Michael Zaidman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fx2hngew.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox