From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][repost] bin_dep.sh Support
Date: Tue, 14 Jul 2009 13:39:12 +0200 [thread overview]
Message-ID: <m2fxcz334v.fsf@ohwell.denx.de> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DDF2695F@SC-VEXCH1.marvell.com> (Prafulla Wadaskar's message of "Mon, 13 Jul 2009 04:39:04 -0700")
Hi Prafulla,
> Then I feel what Jean has suggested is the only way to go ahead with kirkwood use case
> I will go ahead with this.
>
> Ref:
>> > we can simply add a new target
>> > u-boot.kwd
>> > which will do somthing like this
>> >
>> > $(obj)u-boot.kwd: $(obj)u-boot.bin
>> > $(do_image) $(obj)u-boot.kwd $(obj)u-boot.bin
>> > $(obj)board/$(BOARDDIR)/sdramregs.txt
I think this looks good.
> Second issue:
> I will have to add a tool i.e. do_image (to be renamed) which will create u-boot.kwd.
> this tool is specific to Kirkwood only,
> I am going to add this in ./tools/ folder (as per Jean's feedback earlier), is this okay?
The plan as such is ok, although you will probably need to rewrite the
latest version of do_image posted to this ML[1] completely. Starting
out to read the code, I was tempted to post some specific remarks about
the code, but quickly realized that this is not a good attempt to move
further here.
The code really needs to be rewritten in a clean fashion using common
programming metaphors, style and library functions (i.e. use getopt(3),
etc.).
Cheers
Detlev
[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/57251
--
Of course my password is the same as my pet's name
My macaw's name was Q47pY!3 and I change it every 90 days
-- Trevor Linton
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2009-07-14 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 15:26 [U-Boot] [PATCH][repost] bin_dep.sh Support Prafulla Wadaskar
2009-07-13 11:25 ` Wolfgang Denk
2009-07-13 11:39 ` Prafulla Wadaskar
2009-07-14 11:39 ` Detlev Zundel [this message]
2009-07-14 17:04 ` Prafulla Wadaskar
2009-07-16 2:48 ` [U-Boot] [PATCH][repost] mkimage support ( bin_dep.sh Support) Prafulla Wadaskar
2009-07-16 11:24 ` Wolfgang Denk
2009-07-16 16:20 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fxcz334v.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox