From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 03/14] arm/km: convert mgcoge3un target to km_kirkwood
Date: Tue, 03 Jul 2012 16:00:05 +0200 [thread overview]
Message-ID: <m2hatplzbu.fsf@lamuella.denx.de> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A2FE3027C@SC-VEXCH4.marvell.com> (Prafulla Wadaskar's message of "Tue, 3 Jul 2012 06:07:19 -0700")
Hi Prafulla,
[...]
>> But 01-08 are not only bugfixes there are also two new boards in these
>> patches.
>> So will you pull these eight patches in if I post them again without
>> 09-14?
>
> Pls post bug fixes and improvement patches first those will be pulled
> faster.
May I please ask you to reconsider your stance on the patch sets from
Holger? As far as I can see, he explained a few times by now why and
how he grouped the patches like he did. And to be honest, I _can_
understand his reasoning and believe it to be well-founded.
After all, our requirements come from _practical_ considerations,
i.e. bisectability, code size reductions, etc. but in the end they are
all compromises in one way or another. So usually we do not invent new
requirements for the sake of requirements, but in order to improve the
situation if the net effect is positive for the project as a whole.
Of course it is a fact that the effort for reviewers is non-negligible,
but we have to draw a line somewhere in the area where the
"well-formedness" of patch sets and the "ease" of reviewing them needs
to be compromised. I do not like to see added complexity in patch sets
so that reviewing gets easier.
As far as I can see, this is the current situation and thus I would like
you to reconsider and rather spend some more time on the review process
of the whole patch series as it is.
Thanks in advance
Detlev
--
"The number you have dialed is imaginary. Please rotate your phone 90
degrees and try again."
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2012-07-03 14:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 13:33 [U-Boot] [PATCH v2 00/14] updates for Keymile Marvell boards Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 01/14] arm/km: add kmnusa board support Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 02/14] arm/km: add kmcoge5un " Holger Brunck
2012-07-03 8:04 ` Prafulla Wadaskar
2012-07-03 9:37 ` Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 03/14] arm/km: convert mgcoge3un target to km_kirkwood Holger Brunck
2012-07-03 8:05 ` Prafulla Wadaskar
2012-07-03 10:37 ` Holger Brunck
2012-07-03 11:19 ` Prafulla Wadaskar
2012-07-03 12:31 ` Holger Brunck
2012-07-03 12:38 ` Prafulla Wadaskar
2012-07-03 13:00 ` Holger Brunck
2012-07-03 13:07 ` Prafulla Wadaskar
2012-07-03 13:43 ` Holger Brunck
2012-07-03 14:39 ` Prafulla Wadaskar
2012-07-03 18:00 ` Wolfgang Denk
2012-07-04 9:21 ` Prafulla Wadaskar
2012-07-05 5:54 ` Holger Brunck
2012-07-05 6:04 ` Prafulla Wadaskar
2012-07-05 7:15 ` Holger Brunck
2012-07-05 12:09 ` Prafulla Wadaskar
2012-07-05 13:43 ` Holger Brunck
2012-07-05 13:48 ` Prafulla Wadaskar
2012-07-05 15:44 ` Holger Brunck
2012-07-04 8:24 ` Holger Brunck
2012-07-04 9:23 ` Prafulla Wadaskar
2012-07-03 14:00 ` Detlev Zundel [this message]
2012-06-13 13:33 ` [U-Boot] [PATCH v2 04/14] arm/km: remove portl2.h and use km_kirkwood instead Holger Brunck
2012-07-03 8:12 ` Prafulla Wadaskar
2012-06-13 13:33 ` [U-Boot] [PATCH v2 05/14] arm/km: correct init of 88e6352 switch in the reset_phy function Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 06/14] arm/km: enable BOCO2 FPGA download support Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 07/14] arm/km: cleanup km_kirkwood boards Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 08/14] arm/km: redefine piggy 4 reg names to avoid conflicts Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 09/14] arm/km: add support for external switch configuration Holger Brunck
2012-06-26 15:31 ` [U-Boot] [PATCH v3 " Valentin Longchamp
2012-06-13 13:33 ` [U-Boot] [PATCH v2 10/14] arm/km: enable external switch configuration for kmnusa Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 11/14] arm/km: skip FPGA config when already configured Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 12/14] arm/km: support the 2 PCIe fpga resets Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 13/14] arm/km: add implementation for read_dip_switch Holger Brunck
2012-06-13 13:33 ` [U-Boot] [PATCH v2 14/14] arm/km: remove calls to kw_gpio_* in board_early_init_f Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hatplzbu.fsf@lamuella.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox