[U-Boot] [PATCH 3/9] MX51: Add register definitions

Wolfgang Denk
2010-01-18T07:53:22Z

Dear Stefano,

In message <4B54024E.1070103@denx.de> you wrote:
>
> >> +#define PLL_DP_CTL 0x00
> >> +#define PLL_DP_CONFIG 0x04
> >> +#define PLL_DP_OP 0x08
> >> +#define PLL_DP_MFD 0x0C
> >> +#define PLL_DP_MFN 0x10
> >> +#define PLL_DP_MFNMINUS 0x14
> >> +#define PLL_DP_MFNPLUS 0x18
> >> +#define PLL_DP_HFS_OP 0x1C
> >> +#define PLL_DP_HFS_MFD 0x20
> >> +#define PLL_DP_HFS_MFN 0x24
> >> +#define PLL_DP_TOGC 0x28
> >> +#define PLL_DP_DESTAT 0x2C
> >
> > And again.
>
> This is a different fall. These defines are used in the assembly
> lowlevel_init.S in the first initialization. I cannot remove them.
> However, only a part of these defines are currently used and I will drop
> the rest of them.

Such offset definitions should better go into a separate asm-offsets.h
file, as we did for the mpc512x (cpu/mpc512x/asm-offsets.h).

If you have some spare cycles, it would be really great if you could
try and adapt the Linux method of auto-generating the asm-offsets.h
file from the respective C struct declarations - we have a growing
number of such cases so that would be really welcome.

Thanks in advance.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No journaling file system can recover your data if the disk dies.
- Steve Rago in <D4Cw1p.L9E@plc.com>