[U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board

Fabio Estevam
2010-01-11T17:55:24Z

Hi Stefano,

--- On Mon, 1/11/10, Stefano Babic <sbabic@denx.de> wrote:

> From: Stefano Babic <sbabic@denx.de>
> Subject: [U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board
> To: u-boot at lists.denx.de
> Date: Monday, January 11, 2010, 10:26 AM
> The patch adds initial support for
> the Freescale mx51evk board.
> Network (FEC) and SD controller (fsl_esdhc) are supported.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Fred Fan fanyefeng at gmail.com
> +??? puts("Board: MX51 BABBAGE ");

We should use MX51EVK instead.

....

> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_MII
> +#define CONFIG_CMD_NET
> +
> +/* allow to overwrite serial and ethaddr */

> + * The MX51 3stack board seems to have a hardware
> "peculiarity" confirmed under
> + * U-Boot, RedBoot and Linux: the ethernet Rx signal is
> reaching the CS8900A
> + * controller inverted. The controller is capable of
> detecting and correcting
> + * this, but it needs 4 network packets for that. Which
> means, at startup, you
> + * will not receive answers to the first 4 packest, unless
> there have been some
> + * broadcasts on the network, or your board is on a hub.
> Reducing the ARP
> + * timeout from default 5 seconds to 200ms we speed up the
> initial TFTP
> + * transfer, should the user wish one, significantly.

These comments do not apply to MX51EVK as there is no CS8900 controller on this board. Please remove.

...

> +#define CONFIG_SYS_LONGHELP???
> ??? /* undef to save memory */
> +#define CONFIG_SYS_PROMPT???
> ??? "BBG U-Boot > "

'BBG' should be removed as we are no longer using the term Babbage.

I will also send you new optimized values for the DDR settings when I come back to the office.

Regards,

Fabio Estevam