[U-Boot] [PATCH 5/9] serial_mxc: add support for MX51 processor

Wolfgang Denk
2010-01-18T08:45:43Z

Dear Stefano Babic,

In message <4B540AB9.5080602@denx.de> you wrote:
>
> > What happens if - for example - CONFIG_SYS_MX51_UART1 _and_
> > CONFIG_SYS_MX51_UART2 are defiend? How is CONFIG_SERIAL_MULTI going to
> > be supported?
>
> The patch adds only support for the i.MX51 and does

Something missing here ???

> I understand what you mean. However, the driver at moment has the same
> problem with other processors (MX27, MX31). Should be not better to fix
> this issue with another patch that has nothing to do with i.MX51 ?

That's OK with me. But then, this shouldbe documented so nobody tries
to enable more than one serial port.

> There is already a patch by John Rigby to drop them and using a general
> function for all of them. However, you are reviewing my first patchset.

Sorry, I only noticed this later :-(

> In V2 I have already removed the special implementation for MX51 and I
> have added the general function imx_get_uartclk(), as John implemented
> for the other MX processors.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women, and en-
gineers. While the first two are more pleasant, the third is by far
the more certain." -- Baron Rothschild, ca. 1800