public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] arm: fix some arch_number definition
Date: Tue, 27 Jan 2009 13:02:55 +0100	[thread overview]
Message-ID: <m2hc3lj6s0.fsf@ohwell.denx.de> (raw)
In-Reply-To: <20090122111348.GC22829@game.jcrosoft.org> (Jean-Christophe PLAGNIOL-VILLARD's message of "Thu, 22 Jan 2009 12:13:48 +0100")

Hi Jean-Christophe,

>> > > Note that there are other places where this is used - these must be
>> > > changed, too - for example:
>> > > 
>> > > "board/lpc2292sodimm/lpc2292sodimm.c":
>> > > 
>> > >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
>> > >  43         gd->bd->bi_arch_number = 83;
>> > I've not find it in the official list so I've let as 83 (non registered board)
>> 
>> You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
>> not in others? This will cause inconsistent behaviour.
>> 
>> You must not do that.  Either leave ALL of these as they are, or fix
>> ALL of them in the SAME way.
> the other board are not a ARMODILLO correct if I wrong

Why not correct the wrong comment?  I think this is the consistent thing
to do, as there certainly is no definition for "83" in the kernel and 83
has nothing to do with ARMADILLO.

Cheers
  Detlev

PS: You have an interesting Mail-Followup-To on this posting.  Maybe I
    should do this also to cut down on my incoming mails ;)

-- 
Two  monks went  fishing in an  electron river.  The first monk drew out his
network, and out flopped a hacker.  The second monk cried, "The poor hacker!
How can  it live outside of the  network?"   The first monk said,  "When you
have learned to live outside the network, then you will know."
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  parent reply	other threads:[~2009-01-27 12:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  5:51 [U-Boot] [PATCH 0/1] arm/mach-types: sync with 2.6.28 and add generating tools support Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  5:51 ` [U-Boot] [PATCH 1/1] arm: fix some arch_number definition Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  6:51   ` Jens Gehrlein
2009-01-22  8:34     ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-03 11:25       ` Guennadi Liakhovetski
2009-01-22  7:40   ` Wolfgang Denk
2009-01-22  8:29     ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 10:46       ` Wolfgang Denk
2009-01-22 11:13         ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 16:33           ` Wolfgang Denk
2009-01-27 12:02           ` Detlev Zundel [this message]
2009-01-27 12:09             ` Wolfgang Denk
2009-01-27 13:05             ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 11:21   ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  7:42 ` [U-Boot] [PATCH 0/1] arm/mach-types: sync with 2.6.28 and add generating tools support Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2hc3lj6s0.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox