From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Makefile: fix problem with out-of-tree builds introduced by 5013c09f
Date: Wed, 05 Mar 2008 13:46:14 +0100 [thread overview]
Message-ID: <m2hcfl49ux.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1204647095-1894-1-git-send-email-wd@denx.de> (Wolfgang Denk's message of "Tue, 4 Mar 2008 17:11:35 +0100")
Hi Wolfgang,
> Commit 5013c09f (Makefile: cleanup "clean" target) introduced a
> problem for out-of-tree builds which caused "make clean" to fail.
This patch mixes whitespace cleanup with the actual logical change
making it unneccessary hard to read.
Can you please separate cosmetic from logical changes in the future? I
would even have tried to split up the patch, but you already applied it,
so I have not much chance here :(
For things like this I *love* "git-add -i" in the meantime. I cannot
stress enough how easy it is to split changes _after_ the actual editing
into separate commits.
Cheers
Detlev
--
Markov does it in chains.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
prev parent reply other threads:[~2008-03-05 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 16:11 [U-Boot-Users] [PATCH] Makefile: fix problem with out-of-tree builds introduced by 5013c09f Wolfgang Denk
2008-03-05 12:46 ` Detlev Zundel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hcfl49ux.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox