From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Fri, 17 Aug 2012 18:18:13 +0200 Subject: [U-Boot] [PATCH v2] Makefile: fix HAVE_VENDOR_COMMON_LIB In-Reply-To: <20120814201238.551c32e0284cba97ffe0481c@freescale.com> (Kim Phillips's message of "Tue, 14 Aug 2012 20:12:38 -0500") References: <20120814005014.GA13432@tyr.buserror.net> <1344944669-18062-1-git-send-email-daniel.schwierzeck@gmail.com> <20120814201238.551c32e0284cba97ffe0481c@freescale.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, > On Tue, 14 Aug 2012 13:44:29 +0200 > Daniel Schwierzeck wrote: > >> From: Scott Wood >> >> Commit 8b5a02640adf77301f943e8754992c50df004e8a ("Makefile: cosmetic: >> optimize usage of LIBS-y") broke the build of boards that have a board >> vendor "common" directory, by introducing a space between "LIBS-" and >> "y". >> >> Signed-off-by: Scott Wood >> Signed-off-by: Daniel Schwierzeck >> --- >> Changes vor v2: >> - fix the wrong spaces also in spl/Makefile >> >> Tested with: >> MAKEALL spear600 >> MAKEALL -s omap3 >> MAKEALL -s omap4 >> --- > > this fixes newly broken mpc83xx builds, e.g.: > > Configuring for MPC832XEMDS_ATM - Board: MPC832XEMDS, Options: > PQ_MDS_PIB=1,PQ_MDS_PIB_ATM=1 > make: *** [u-boot] Error 1 > powerpc-fsl-linux-size: './u-boot': No such file > board/freescale/mpc832xemds/libmpc832xemds.o: In function > board_early_init_r': > /home/r1aaha/git/u-boot/board/freescale/mpc832xemds/mpc832xemds.c:90: > undefined reference to `pib_init' > make: *** [u-boot] Error 1 > > So, > > Acked-by: Kim Phillips Applied, thanks. Cheers Detlev -- Science is a way of thinking much more than it is a body of knowledge. -- Carl Sagan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de