From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Mon, 28 Mar 2011 18:11:37 +0200 Subject: [U-Boot] [PATCH] cfi_flash: fix bug with flash banks with different sector numbers In-Reply-To: <201103281800.10029.sr@denx.de> (Stefan Roese's message of "Mon, 28 Mar 2011 18:00:09 +0200") References: <1300727276-10204-1-git-send-email-martin.krause@tqs.de> <201103281800.10029.sr@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, > Hi Detlev, > > On Monday 28 March 2011 17:55:03 Detlev Zundel wrote: >> > The function find_sector() does not take into account if the flash bank >> > has changed since the last call. This could lead to illegal accesses >> > inside and beyond the flash_info_t info strcture. For example if the >> > current flash bank has less sectors than the last used flash bank. >> > >> > This patch adds two cheks. One that insures, that the current sector does >> > not exceed the allowed maximum (which is always a good idea). And one >> > that checks if the current access is to the same flash bank as the last >> > access. If not, the search loop will start with sector 0. >> > >> > Signed-off-by: Martin Krause >> >> Can you please comment on Martins fix? Thanks! > > I already did and asked for a non line-wrapped patch version: > > http://lists.denx.de/pipermail/u-boot/2011-March/088950.html > > Still no answer though. Martin, how is your schedule here? Will you find the > time to send an updated patch shortly? Well actually I followed up to a patch version that Martin sent out pretty much immediately and which I can apply without problems. Can you please try again if the patch works for you also? Thanks! Detlev -- I have always observed that the pretensions of all people are in exact inverse ratio to their merits; this is one of the axioms of morals. -- Joseph Lagrange -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de