From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] git merge summary
Date: Tue, 21 Dec 2010 16:24:20 +0100 [thread overview]
Message-ID: <m2k4j3xi6z.fsf@ohwell.denx.de> (raw)
In-Reply-To: <20101221143628.57A83126EB19@gemini.denx.de> (Wolfgang Denk's message of "Tue, 21 Dec 2010 15:36:28 +0100")
Hi Wolfgang,
> Dear Detlev Zundel,
>
> In message <m2sjxrxm38.fsf@ohwell.denx.de> you wrote:
>>
>> > may I ask again for opinions about enabling that feature?
>>
>> I also would like to see it. Wolfgang, is there anything that you
>> don't like about this option?
>
> There is two things that make me hesitate:
>
> 1) I wonder if it might have negative side effects. If it was
> generally considered a good thing I would expect that it was set
> as default, but it ain't.
Personally I cannot think of negative side effects. Checking recent
linux commits, it seems Linus is using this himself[1] which would be a
pro argument I guess.
> 2) I don't know what exactly needs to be done. My understandaning is
> that I can either switch this on globally for all repositories I'm
> working with (which I do not like), or it needs to be set manually
> in each and every clone of the U-Boot repo where a merge might be
> done.
As far as I can see, we should turn it on per repo so that (future)
custodians would get the setting through cloning. Apart from that I
even don't see anything against turning it on globally.
> When I throw away a repo for some reason and start with a new clone,
> I can be pretty sure that I will forget to re-enable this.
Then we should enable it in "the master" repo from which you clone.
> What needs to be done about custodian repos etc.?
As far as I understand it, we cannot change anything in already cloned
repositories, so every custodian would need to do this configuration.
On the other hand we can add this setting (yes, I volunteer) on our git
server for all repos, so future clones will get it.
> In other words, it sounds like a thing that causes effort and can go
> wrong nevertheless.
It will cause effort, yes, alas I don't see what can go wrong. It will
be a policy that we can never enforce for individual users, so there
remains a chance that individuals will do merges without the setting.
On the other hand, I guess what really counts is whether _you_ (doing
all practically relevant merges) use it or not. So essentially it is a
question of whether you can add that in all of your repos.
> So I'd rather wait until either this option is used as defualt by some
> new version of git, or at least until there is a broader request and
> consensus among the custodians.
In this thread you previously wrote:
> If there is an agreement (or at least no protests) we can add
> 'merge.log'.
>
> Shall we?
Have you become more pessimistic?
Cheers
Detlev
[1] http://git.denx.de/?p=linux-2.6-denx.git;a=commit;h=8cad7f06e3b1d3f9a28bb7385e8fc09d5e1bf84c
--
#!/usr/bin/perl
$c="print\"\#\!\/usr\/bin\/perl\
\\\$c\=\\\"\"\.quotemeta\(\$c\)\.\"\\\"\;\\n\$c;\"";
print"#!/usr/bin/perl\n\$c=\"".quotemeta($c)."\";\n$c;";
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2010-12-21 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 21:18 [U-Boot] git merge summary Alexander Holler
2010-03-29 9:32 ` Detlev Zundel
2010-03-29 10:44 ` Wolfgang Denk
2010-12-18 22:50 ` Alexander Holler
2010-12-21 14:00 ` Detlev Zundel
2010-12-21 14:36 ` Wolfgang Denk
2010-12-21 15:24 ` Detlev Zundel [this message]
2011-01-09 16:25 ` Wolfgang Denk
2011-01-10 5:20 ` Mike Frysinger
2011-01-12 17:47 ` Detlev Zundel
2011-01-12 18:13 ` Stefan Roese
2011-03-11 0:34 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k4j3xi6z.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox