From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] POST related question
Date: Wed, 10 Feb 2010 16:54:11 +0100 [thread overview]
Message-ID: <m2k4ulrsrg.fsf@ohwell.denx.de> (raw)
In-Reply-To: <660c0f821002100636l2e6f892ak7e435d7b069ed371@mail.gmail.com> (Michael Zaidman's message of "Wed, 10 Feb 2010 16:36:30 +0200")
Hi Michael,
> Working on the POST for our board (which I am going to submit
> to the u-boot in the near future) I was asked to output the POST tests
> sequence progress to the dedicated LEDs (current test?s index and
> test?s result ? PASS or FAIL) in addition to the conventional console
> output. Such indication can be helpful at the customer premises when
> console is not available as well as at the production testing/diagnostics
> to understand which POST test has failed while serial console does not
> show signs of life.
> In order to fulfill this requirement I see two possibilities:
>
> 1) Common infrastructure change - add pre-test and after test callbacks
> to the post_test structure in the tests.c file. Call these callbacks
> before and after each POST test in the post_run_single routine of post.c file.
>
> 2) Local, board specific change ? duplicate all necessary POST tests into
> specific board folder and add output to LEDs interface into every
> xxxx_post_test routine.
>
> Please advise.
Thinking about it, why can't we 3) introduce show_post_progress(). It
seems to me that the show_boot_progress (grep the README) implements
exactly the same idea for the boot process, so it would make sense to
re-use the implementation idea. Nowadays we could solve the overrideing
with weak functions.
What do you think?
Cheers
Detlev
--
It's very important that you sleep because that's when your brain is
garbage collecting. And a dream is if you are interrupted in the
middle and have junk left in the registers.
-- Gerald Sussman
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2010-02-10 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 9:59 [U-Boot] POST related question Michael Zaidman
[not found] ` <20100210132826.3221C4C04E@gemini.denx.de>
2010-02-10 14:33 ` Michael Zaidman
2010-02-10 14:36 ` Michael Zaidman
2010-02-10 15:54 ` Detlev Zundel [this message]
2010-02-11 8:53 ` Michael Zaidman
2010-02-11 9:49 ` Detlev Zundel
2010-02-11 10:29 ` Michael Zaidman
2010-02-11 11:43 ` Detlev Zundel
2010-02-11 12:49 ` Michael Zaidman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k4ulrsrg.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox