From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Wed, 10 Feb 2010 16:54:11 +0100 Subject: [U-Boot] POST related question In-Reply-To: <660c0f821002100636l2e6f892ak7e435d7b069ed371@mail.gmail.com> (Michael Zaidman's message of "Wed, 10 Feb 2010 16:36:30 +0200") References: <660c0f821002100159i1a956edfx1c76945042f51954@mail.gmail.com> <20100210132826.3221C4C04E@gemini.denx.de> <660c0f821002100633p25db73aaybd3aa42fca94f4e1@mail.gmail.com> <660c0f821002100636l2e6f892ak7e435d7b069ed371@mail.gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michael, > Working on the POST for our board (which I am going to submit > to the u-boot in the near future) I was asked to output the POST tests > sequence progress to the dedicated LEDs (current test?s index and > test?s result ? PASS or FAIL) in addition to the conventional console > output. Such indication can be helpful at the customer premises when > console is not available as well as at the production testing/diagnostics > to understand which POST test has failed while serial console does not > show signs of life. > In order to fulfill this requirement I see two possibilities: > > 1) Common infrastructure change - add pre-test and after test callbacks > to the post_test structure in the tests.c file. Call these callbacks > before and after each POST test in the post_run_single routine of post.c file. > > 2) Local, board specific change ? duplicate all necessary POST tests into > specific board folder and add output to LEDs interface into every > xxxx_post_test routine. > > Please advise. Thinking about it, why can't we 3) introduce show_post_progress(). It seems to me that the show_boot_progress (grep the README) implements exactly the same idea for the boot process, so it would make sense to re-use the implementation idea. Nowadays we could solve the overrideing with weak functions. What do you think? Cheers Detlev -- It's very important that you sleep because that's when your brain is garbage collecting. And a dream is if you are interrupted in the middle and have junk left in the registers. -- Gerald Sussman -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de