public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Policy for checkpatch usage?
Date: Wed, 20 Apr 2011 11:24:48 +0200	[thread overview]
Message-ID: <m2liz5gtr3.fsf@ohwell.denx.de> (raw)

Hi,

currently our CodingStyle[1] has this to say about checkpatch.pl:

  Make sure to run the checkpatch.pl script from the Linux source tree
  to check your patches. Note that this should be done before posting on
  the mailing list!

Now this is not very clear as to what should be done with regard to the
results of such a checkpatch run.  I think we all agree that warnings
tailored to the linux kernel like this can be ignored:

  WARNING: consider using kstrto* in preference to simple_strtol
  #215: FILE: net/tftp.c:619:
  +		TftpRemotePort = simple_strtol(ep, NULL, 10);

             reply	other threads:[~2011-04-20  9:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20  9:24 Detlev Zundel [this message]
2011-04-20 10:15 ` [U-Boot] Policy for checkpatch usage? Graeme Russ
2011-04-20 12:43   ` Graeme Russ
2011-04-20 13:40     ` Detlev Zundel
2011-04-20 13:38   ` Detlev Zundel
2011-04-20 16:51   ` Scott Wood
2011-04-21  0:09     ` Graeme Russ
2011-04-21  5:18       ` Wolfgang Denk
2011-04-21 14:24         ` Detlev Zundel
2011-04-21 14:29     ` Detlev Zundel
2011-04-21 14:49       ` Eric Cooper
2011-04-21 14:56         ` Fabian Cenedese
2011-04-21 15:04           ` Eric Cooper
2011-04-21 15:37             ` Detlev Zundel
2011-04-21 15:19           ` Detlev Zundel
2011-04-21 15:46         ` Detlev Zundel
2011-04-23 15:29           ` Andreas Pretzsch
2011-04-27  9:07             ` Detlev Zundel
2011-04-21 16:10       ` Scott Wood
2011-04-22  0:43         ` Graeme Russ
2011-04-22  6:18           ` Albert ARIBAUD
2011-04-22 10:56             ` Graeme Russ
2011-04-22  8:54           ` Wolfgang Denk
2011-04-22 10:52             ` Graeme Russ
2011-04-22 12:46               ` Wolfgang Denk
2011-04-25  5:37                 ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2liz5gtr3.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox