[U-Boot] [PATCH] da850: add cache management support in config file

Netagunte, Nagabhushana
2011-08-01T09:44:36Z

Detlev,
Thanks for your comments, I will make appropriate changes to 'commit' message.
-Nag
On Fri, Jul 29, 2011 at 13:56:32, Detlev Zundel wrote:
> Hi,
>
> > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> >
> > add support for cache management in config file. This is needed as per
> > new cache management framework. da850 doesnt support I-CACHE, D-CACHE
> > or L2-CACHE usage which is indicated by following definitions,
> >
> > 1. CONFIG_SYS_ICACHE_OFF
> > 2. CONFIG_SYS_DCACHE_OFF
> > 3. CONFIG_SYS_L2CACHE_OFF
>
> This commit message makes no sense for me. You "add support" for something which essentially is "not supported" as you say. If you are trying to fix compile problems, then please say so.
>
> Cheers
> Detlev
>
> --
> ... that every year or so they're going to give you a new release full of 50 000 additional lines of code all written by monkeys. Because
> they generally follow the ``million monkeys typing, and eventually
> they'll come up with something useful'' school of system development.
> -- Richard M. Stallman
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
>