[U-Boot] [PATCH] da8xx: add support for multiple PLL controllers

Detlev Zundel
2011-07-29T08:41:41Z

Hi,

[...]

> - pre_div = (readl(&davinci_pllc_regs->prediv) &
> - DAVINCI_PLLC_DIV_MASK) + 1;
> - pllm = readl(&davinci_pllc_regs->pllm) + 1;
> + pre_div = (REG(pll_base + PLLC_PREDIV) & 0xff) + 1;
> + pllm = REG(pll_base + PLLC_PLLM) + 1;

Nack - do not change "common" accessors into local macros. We should
really strive to have a common base here. See also

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104428

Cheers
Detlev

--
He thinks he's really smooth, but he's only C^1.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de