[U-Boot] [PATCH] da850: read MAC address from I2C EEPROM on AM18xx EVM

Netagunte, Nagabhushana
2011-08-01T09:50:37Z

Hi Mike,
Thanks for your comments.

Since the earlier patch is about reading env variable value in SPI flash and
This patch concentrates on reading the same from I2C EEPROM, it will be better to have 2 different patches. Second patch is not to fix the first patch.

If you want them to sent after squashing, I can do that as well.

Regards,
Nag

On Sat, Jul 30, 2011 at 00:02:41, Mike Frysinger wrote:
> On Thu, Jul 28, 2011 at 11:31, Mike Frysinger wrote:
> > On Thu, Jul 28, 2011 at 09:25, ?<nagabhushana.netagunte@wrote:
> >> ? ? ? ?if (getenv("ethaddr") == NULL) {
> >
> > this should get fixed to use the eth helper instead of poking the env
> > yourself. ?see board/bf537-stamp/bf537-stamp.c as an example.
>
> actually, it looks like this patch is simply a fix for another patch you just sent out. please dont post buggy patches ... just squash the two together.
>
> also, if you're posting patch series, you need to have [#/#] markers in the summary so that people can clearly see the order required for merging.
> -mike
>