From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Thu, 21 Apr 2011 16:24:32 +0200 Subject: [U-Boot] Policy for checkpatch usage? In-Reply-To: <20110421051851.5CF64101D76@gemini.denx.de> (Wolfgang Denk's message of "Thu, 21 Apr 2011 07:18:51 +0200") References: <20110420115129.2a70418b@schlenkerla.am.freescale.net> <20110421051851.5CF64101D76@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, > Dear Graeme Russ, > > In message you wrote: >> >> What about my other suggestion - A checkpatch summary with an expalation >> for any warnings or errors? See for example my heads-up for checkpatch >> warnings - http://lists.denx.de/pipermail/u-boot/2011-April/090144.html > > For issues like this one should do what the last lines of the > checkpatch output say: "If any of these errors are false positives > report them to the maintainer, see CHECKPATCH in MAINTAINERS." But as I showed, we already know that we do have false positives in U-Boot as we miss some Linux constructs. We should refrain from taking this as "false positives" to the checkpatch maintainers. Either we can suppress them somehow or maybe we should list them? Cheers Detlev -- Warning: this comic occasionally contains strong language (which may be unsuit- able for children), unusual humor (which may be unsuitable for adults), and ad- vanced mathematics (which may be unsuitable for liberal-arts majors). /xkcd.org -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de