From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Wed, 22 Sep 2010 17:07:25 +0200 Subject: [U-Boot] [PATCH] p1022ds: add video support In-Reply-To: <4C99393F.8010301@freescale.com> (Timur Tabi's message of "Tue, 21 Sep 2010 18:01:19 -0500") References: <1283459719-23354-1-git-send-email-timur@freescale.com> <20100921235628.580f1a4a@wker> <4C992AF3.5030001@freescale.com> <20100922005700.499ce44d@wker> <4C99393F.8010301@freescale.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Timur, > Anatolij Gustschin wrote: >>> Also, I thought it would be better to provide some sort of completeness for the >>> > bits I am using. >> We do not add unused code. > > Well, I don't see how macros are "unused code", but I'll delete those lines. > >>>> > > CONFIG_VIDEO definition should depend on CONFIG_FSL_DIU_FB, >>>> > > I think. Otherwise the building won't succeed if CONFIG_FSL_DIU_FB >>>> > > is not defined (due to absence of video_hw_init()). >>> > >>> > We need the DIU initialized, even if U-Boot doesn't use it. This is what >>> > CONFIG_FSL_DIU_FB does. CONFIG_VIDEO then tells U-Boot to actually use the DIU. > >> I understand it. I didn't say you should make CONFIG_FSL_DIU_FB >> dependent on CONFIG_VIDEO, but the opposite. > > Ok. > >> On the other site, one of the design principles states: >> >> initialize devices only when they are needed within U-Boot. > > Well, I'll try to work toward that, but I'm pretty sure there are plenty of > devices that are initialized but not used in U-Boot already. This "but there are other examples doing just the same!" arguing is getting tiresome. Please accept that this is not an argument capable of convincing people - the opposite is true. Is there a technical reason why the initialization has to be in U-Boot? Cheers Detlev -- Less talking -- more hacking -- Olin Shivers -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de