From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Tue, 07 Apr 2009 20:41:18 +0200 Subject: [U-Boot] [PATCH] Add support to Colibri PXA-270 board In-Reply-To: <9e0cf0bf0904071126u4f0cf332x35fb378dcc5c1979@mail.gmail.com> (Alon Bar-Lev's message of "Tue, 7 Apr 2009 21:26:18 +0300") References: <200904071156.06536.alon.barlev@gmail.com> <9e0cf0bf0904071016j2fc2cdddt93a9f1155e211193@mail.gmail.com> <9e0cf0bf0904071126u4f0cf332x35fb378dcc5c1979@mail.gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alon, > I don't understand why you are so angry... Maybe because you misunderstood me. Let me assure you, that I'm not angry. I only wanted to make a clear statement that there are people on this list who spend really lots of time in the "unsexy job" of cleaning up code. This usually takes way longer than writing new code and of course this is also completely invisible to the casual reader of the sorce code. One also never gets any return from it, because one "does not add any new shiny features". Because of this, not many people attend to this type of work, so what I try to do is to ensure that we *need as few cleanup as possible* right upfront. > There is no simple implementation of code reuse within the boards. Are you sure? You did not look very hard then. In a strict sense it may be true that "board directories" do not share much code (although even that is done by some), but this is missing the point. If something proves to be board-independent, it usually means it is only architecture specific, so it can go there and be reused by *all* boards of that architecture. > You know the code much better than I do. > Please free to drop this implementation. Oh please, we really value all contributions, but if we were to accept everything unconditionally, the code would explode in no time. Please reconsider and try to reuse the code instead of copying it. Maybe put it into pxa270 specific places. Maybe Stefano has some good ideas? Cheers Detlev -- Markov does it in chains. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de