public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support to Colibri PXA-270 board
Date: Tue, 07 Apr 2009 13:55:37 +0200	[thread overview]
Message-ID: <m2ocv865l1.fsf@ohwell.denx.de> (raw)
In-Reply-To: <200904071156.06536.alon.barlev@gmail.com> (Alon Bar-Lev's message of "Tue, 7 Apr 2009 11:56:06 +0300")

Hi Alon,

a new board port without a single (C)opyright by your name - must have
been a hard day copying ;)

> This configuration is based on the trizepsiv board, and the
> work Daniel Mack did in the past [1].
>
> The following files were taken as-is from trizepsiv board:
>  - lowlevel_init.S
>  - pxavoltage.S
>  - u-boot.lds

Isn't this a clear sign to try and find a way to reuse the code for both
boards?  Simply copying a file verbatim is always a mistake.  Who will
copy the bugfixes in the future?

I added Stefano on CC, maybe he has some good input on how to share code
here.

Cheers
  Detlev

-- 
Today people don't go to rock concerts to listen to the music, because
you can't. They go there to be part of the environment.
                                       -- Peter Eisenman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2009-04-07 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  8:56 [U-Boot] [PATCH] Add support to Colibri PXA-270 board Alon Bar-Lev
2009-04-07 11:55 ` Detlev Zundel [this message]
2009-04-07 17:16   ` Alon Bar-Lev
2009-04-07 18:22     ` Detlev Zundel
2009-04-07 18:26       ` Alon Bar-Lev
2009-04-07 18:41         ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ocv865l1.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox