public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Compilation warning: "MSR_RI" redefined
Date: Thu, 02 Apr 2009 10:55:00 +0200	[thread overview]
Message-ID: <m2ocvfcu57.fsf@ohwell.denx.de> (raw)
In-Reply-To: <200904020856.46825.sr@denx.de> (Stefan Roese's message of "Thu,  2 Apr 2009 08:56:46 +0200")

Hi Stefan,

> your patch 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware 
> diagnosis functions for inka4x0] introduced all kind of new defines in the 
> ns16550.h header resulting in a warning on some 4xx platforms:
>
> [stefan at kubuntu u-boot (master)]$ ./MAKEALL ml300
> Configuring for ml300 board...
> In file included from serial.c:53:
> /home/stefan/git/u-boot/u-boot/include/ns16550.h:151:1: warning: "MSR_RI" 
> redefined
> In file included from serial.c:41:
> /home/stefan/git/u-boot/u-boot/include/asm/processor.h:48:1: warning: this is 
> the location of the previous definition
>
> I suggest to either remove this MSI_RI from the header again (it doesn't seem 
> to be used here) or rename it.

Ok, so much for the plan to add the defines not bit by bit as needed,
but register-wise, while we're there.

I actually would prefer to use UART_MSR_RI, as this is a UART thingy
rather than to remove the define as we surely use the register, so I
feel it worthwhile to have the whole definition on board.

Let me cook up a rename for the UART stuff..

Cheers
  Detlev

-- 
We have a live-manual.  It's called emacs-devel at gnu.org.
You can stick to just reading it, but you can skip to a specific chapter
by simply sending an email asking for it ;-)
                                    -- Stefan Monnier
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2009-04-02  8:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  6:56 [U-Boot] Compilation warning: "MSR_RI" redefined Stefan Roese
2009-04-02  8:55 ` Detlev Zundel [this message]
2009-04-02  9:03   ` Stefan Roese
2009-04-02 13:26     ` Kumar Gala
2009-04-03 11:12       ` Detlev Zundel
2009-04-03 20:35         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ocvfcu57.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox