public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] POST cleanup.
Date: Wed, 12 May 2010 14:02:43 +0200	[thread overview]
Message-ID: <m2pr11nx98.fsf@ohwell.denx.de> (raw)
In-Reply-To: <AANLkTintKZHVs12KXQvJ_4IGuCQIzgx7oMosdFwuS_PG@mail.gmail.com> (Michael Zaidman's message of "Mon, 10 May 2010 14:39:34 +0300")

Hi Michael,

>>> diff --git a/board/barco/barco.c b/board/barco/barco.c
>>> index c5fe8c4..2d01f1b 100644
>>> --- a/board/barco/barco.c
>>> +++ b/board/barco/barco.c
>>> @@ -348,12 +348,3 @@ int serial_tstc (void)
>>> ?{
>>> ? ? ? return 0;
>>> ?}
>>> -
>>> -unsigned long post_word_load (void)
>>> -{
>>> - ? ? return 0l;
>>> -}
>>> -void post_word_store (unsigned long val)
>>> -{
>>> - ? ? return;
>>> -}
>>
>> This never worked :) ?The config file has no trace of any POST, so the
>> change you do is pretty useless:
>
> These changes are necessary for CONFIG_LOGBUFFER which barco board
> defines that in turn requires the post_word_load and post_word_store
> support.

Hm.  It amazes me that CONFIG_LOGBUFFER needs a
CONFIG_SYS_POST_WORD_ADDR - I simply did not realize this.  

Ah, I see now that post.h produces these values when CONFIG_POST _or_
CONFIG_LOGBUFFER is defined.  I guess this works, but it is non-obvious
that we need post.h if no POST is used.  But still this is no reason to
NAK the patch.

Cheers
  Detlev

-- 
This is  not the first  time my views  on some topic have  inspired in
someone the  desire to psychoanalyze me. Previous  experience leads me
to ask  about your couch. Is  it comfortable? Are its  springs in good
shape?                                     -- Jonh McCarthy
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2010-05-12 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-02 10:38 [U-Boot] [PATCH v3] POST cleanup v3 (incremental) Michael Zaidman
2010-05-06 21:42 ` Wolfgang Denk
2010-05-09 15:27   ` [U-Boot] [PATCH v4] POST cleanup Michael Zaidman
2010-05-10 11:17     ` Detlev Zundel
2010-05-10 11:39       ` Michael Zaidman
2010-05-12 12:02         ` Detlev Zundel [this message]
2010-05-12 12:49           ` Michael Zaidman
2010-06-27 14:00             ` Michael Zaidman
2010-05-10 12:12       ` Michael Zaidman
2010-05-10 13:33       ` [U-Boot] [PATCH v5] " Michael Zaidman
2010-06-29 19:51         ` Wolfgang Denk
2010-06-30 16:16           ` [U-Boot] [PATCH v6] " Michael Zaidman
2010-08-08  6:53             ` Michael Zaidman
2010-08-08 20:30               ` Wolfgang Denk
2010-08-10 13:37                 ` Michael Zaidman
2010-09-20  6:51                 ` [U-Boot] [PATCH V7] " Michael Zaidman
2010-09-21 19:40                   ` Wolfgang Denk
2010-10-26 21:09                   ` Wolfgang Denk
2010-11-13 22:55                     ` Wolfgang Denk
2010-11-21 12:34                     ` Michael Zaidman
2010-12-06  8:00                       ` Michael Zaidman
2010-05-10 11:51     ` [U-Boot] [PATCH v4] " Anatolij Gustschin
2010-05-10 11:55       ` Michael Zaidman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2pr11nx98.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox