From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH,V2] JFFS2: accelerate scanning.
Date: Tue, 19 Apr 2011 17:15:03 +0200 [thread overview]
Message-ID: <m2r58yi87c.fsf@ohwell.denx.de> (raw)
In-Reply-To: <000001cbfcbd$59578ec0$6401a8c0@LENOVOE5CA6843> (Baidu Liu's message of "Sun, 17 Apr 2011 13:06:52 +0800")
Hi Baidu,
> Syncs up with jffs2 in the linux kernel:
> 1/ Change DEFAULT_EMPTY_SCAN_SIZE from 4KB to 256 Bytes.
> 2/ If the 1KB data is 0xFF after the cleanmarker, skip
> and scan the next sector.
> 3/ Change the buffer size from 4KB to 128KB which is the
> common size of erase block.
There is no "common size of erase block". Looking into the Linux code,
it uses "max(erase block size, 128k)" for its buffer to speed up reading
from NAND and the 128k seem to be a kmalloc limit.
So maybe a "increase buffer size from 4KiB to 128KiB to reduce number of
read operations" would be more fitting. By the way, does this change
contribute to the performance increase at all, or is the increase simply
due to DEFAULT_EMPTY_SCAN_SIZE?
Also as for the other patch, can you split the commit into the
individual changes corresponding to the list items? In this way, one
could also easily measure which change really speeds up the operation...
Thanks!
Detlev
--
It is practically impossible to teach good programming to students that have
had a prior exposure to BASIC: as potential programmers they are mentally
mutilated beyond hope of regeneration. -- Edsger Dijkstra
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-04-19 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 5:06 [U-Boot] [PATCH,V2] JFFS2: accelerate scanning Baidu Liu
2011-04-19 15:15 ` Detlev Zundel [this message]
2011-04-24 3:43 ` Baidu Liu
2011-04-27 9:43 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r58yi87c.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox