From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/7] drivers/twserial: Add protocol driver for "three wire serial" interface.
Date: Thu, 26 Mar 2009 10:33:12 +0100 [thread overview]
Message-ID: <m2r60kmxwn.fsf@ohwell.denx.de> (raw)
In-Reply-To: <20090325191902.7B8C9832E406@gemini.denx.de> (Wolfgang Denk's message of "Wed, 25 Mar 2009 20:19:02 +0100")
Hi Wolfgang,
> Dear Detlev Zundel,
>
> In message <1237998478-18452-4-git-send-email-dzu@denx.de> you wrote:
>> This pretty unintelligent interface is used on some RTC chips.
>>
>> Signed-off-by: Detlev Zundel <dzu@denx.de>
> ...
>> diff --git a/include/tws.h b/include/tws.h
>> new file mode 100644
>> index 0000000..bfa8d58
>> --- /dev/null
>> +++ b/include/tws.h
>> @@ -0,0 +1,47 @@
> ...
>> +#ifndef _TWS_H_
>> +#define _TWS_H_
>> +
>> +#ifndef TWS_SOFT_DECLARATIONS
>> +# if defined(CONFIG_MPC5xxx)
>> +# define TWS_SOFT_DECLARATIONS \
>> + volatile ioport_t *iop = ioport_addr((immap_t *)CONFIG_SYS_IMMR, I2C_PORT);
>> +# else
>> +# define TWS_SOFT_DECLARATIONS
>> +# endif
>> +#endif
>
> Indentation not by TAB.
Yes, intentionally so. Indenting by TAB exceeds the available line
length. Judging by this single line I felt non-breaking the line was
more important.
Can you please point me to the section in the CodingStyle regarding
indentation for macros? I'd be much obliged.
Thanks
Detlev
--
"It's amazing I won. I was running against peace, prosperity, and
incumbency."
-- George H.W. Bush, 06/14/2001, talking to Swedish prime
minister Goran Perrson, unaware that a live tv camera was still on
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2009-03-26 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 16:27 [U-Boot] [PATCH v2 0/7] Update for inka4x0 plus some new features Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 1/7] command.c: Expose the core of do_help as _do_help to the rest of u-boot Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 2/7] mpc5xxx: Add structure definition for several more register blocks Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 3/7] drivers/twserial: Add protocol driver for "three wire serial" interface Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 4/7] rtc: add support for 4543 RTC (manufactured by e.g. EPSON) Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 5/7] inka4x0: Add hardware diagnosis functions for inka4x0 Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 6/7] inka4x0: Add hardware diagnosis and RTC in configuration Detlev Zundel
2009-03-25 16:27 ` [U-Boot] [PATCH v2 7/7] inka4x0: Use proper accessor macros for memory mapped registers Detlev Zundel
2009-03-27 10:33 ` [U-Boot] [PATCH v2 4/7] rtc: add support for 4543 RTC (manufactured by e.g. EPSON) Anatolij Gustschin
2009-03-27 10:51 ` Wolfgang Denk
2009-03-27 11:13 ` Detlev Zundel
2009-03-27 12:43 ` Anatolij Gustschin
2009-03-27 12:53 ` Jerry Van Baren
2009-03-27 13:00 ` Detlev Zundel
2009-03-27 16:06 ` Scott Wood
2009-03-25 19:19 ` [U-Boot] [PATCH v2 3/7] drivers/twserial: Add protocol driver for "three wire serial" interface Wolfgang Denk
2009-03-26 9:33 ` Detlev Zundel [this message]
2009-03-26 15:23 ` Detlev Zundel
2009-03-27 20:08 ` Wolfgang Denk
2009-03-27 10:02 ` Anatolij Gustschin
2009-03-27 10:33 ` Detlev Zundel
2009-03-27 20:06 ` [U-Boot] [PATCH v2 1/7] command.c: Expose the core of do_help as _do_help to the rest of u-boot Wolfgang Denk
2009-03-25 16:36 ` [U-Boot] [PATCH v2 0/7] Update for inka4x0 plus some new features Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r60kmxwn.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox