From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure
Date: Fri, 08 Apr 2011 13:44:35 +0200 [thread overview]
Message-ID: <m2sjttdl24.fsf@ohwell.denx.de> (raw)
In-Reply-To: <BANLkTi=dDoa-bk5ai6zvU4DPWHoFdj3SkQ@mail.gmail.com> (Mike Frysinger's message of "Thu, 7 Apr 2011 15:43:04 -0400")
Hi,
> On Thu, Apr 7, 2011 at 10:13 AM, Andy Fleming wrote:
>> On Apr 6, 2011, at 7:07 AM, Detlev Zundel wrote:
>>>> This second version cleans up all checkpatch errors that I reasonably could,
>>>> and addresses most of the comments from the first round of reviews.
>>>
>>> ?WARNING: Use of volatile is usually wrong: see
>>> Documentation/volatile-considered-harmful.txt
>>> ?#1299: FILE: drivers/net/tsec.c:1740:
>>> ?+static int tsec_send(struct eth_device *dev, volatile void *packet, int length)
>>>
>>> Ah I see. ?This is needed because include/net.h prescribes this as the
>>> interface. ?Oh well, we should clean this up at some later point, so
>>> it's ok from my perspective to ignore this and at least stay consistent.
>>>
>>> ?WARNING: do not add new typedefs
>>> ?#4271: FILE: include/phy.h:389:
>>> ?+typedef enum {
>>>
>>> I know that we have lots of typedefs, but we should not add new ones.
>>> Actually not using this typedef for an enum-type would make the sources
>>> easier for me to read as I don't have to do this extra lookup step.
>>
>> True, but this typedef is in Linux the same way. It seemed sensible to keep them the same
>
> agreed. fwiw :p.
I'm also fine with that.
Cheers
Detlev
--
Warning: this comic occasionally contains strong language (which may be unsuit-
able for children), unusual humor (which may be unsuitable for adults), and ad-
vanced mathematics (which may be unsuitable for liberal-arts majors). /xkcd.org
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
prev parent reply other threads:[~2011-04-08 11:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 21:59 [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 1/6] tsec: use IO accessors for IO accesses Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 2/6] tsec: arrange the code to avoid useless function declaration Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 3/6] Remove instances of phy_read/write Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec Andy Fleming
2011-04-05 21:59 ` [U-Boot] [PATCH v2 6/6] tsec: Convert tsec to use PHY Lib Andy Fleming
2011-04-06 13:02 ` Detlev Zundel
2011-04-06 13:01 ` [U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec Detlev Zundel
2011-04-06 22:50 ` Mike Frysinger
2011-04-06 12:56 ` [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot Detlev Zundel
2011-04-06 23:09 ` Mike Frysinger
2011-04-07 14:16 ` Andy Fleming
2011-04-07 15:01 ` Wolfgang Denk
2011-04-07 19:37 ` Mike Frysinger
2011-04-07 4:43 ` Wolfgang Denk
2011-04-07 4:47 ` Mike Frysinger
2011-04-07 7:12 ` Wolfgang Denk
2011-04-07 5:19 ` Wolfgang Denk
2011-04-06 12:32 ` [U-Boot] [PATCH v2 3/6] Remove instances of phy_read/write Detlev Zundel
2011-04-06 12:31 ` [U-Boot] [PATCH v2 2/6] tsec: arrange the code to avoid useless function declaration Detlev Zundel
2011-04-06 12:29 ` [U-Boot] [PATCH v2 1/6] tsec: use IO accessors for IO accesses Detlev Zundel
2011-04-06 12:32 ` Kumar Gala
2011-04-06 12:07 ` [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure Detlev Zundel
2011-04-07 14:13 ` Andy Fleming
2011-04-07 19:43 ` Mike Frysinger
2011-04-08 11:44 ` Detlev Zundel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sjttdl24.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox