From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] tsec: arrange the code to avoid useless function declaration
Date: Wed, 30 Mar 2011 13:07:40 +0200 [thread overview]
Message-ID: <m2tyekn9xf.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1301427010-7429-3-git-send-email-afleming@freescale.com> (Andy Fleming's message of "Tue, 29 Mar 2011 14:30:05 -0500")
Hi Andy,
> From: Mingkai Hu <Mingkai.hu@freescale.com>
>
> Signed-off-by: Mingkai Hu <Mingkai.hu@freescale.com>
> Acked-by: Andy Fleming <afleming@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/net/tsec.c | 857 +++++++++++++++++++++++++---------------------------
> 1 files changed, 416 insertions(+), 441 deletions(-)
Does this patch really only rearrange code and not change any
functionality? In this case this information should be in the commit
message IMHO.
Cheers
Detlev
--
It is practically impossible to teach good programming to students that have
had a prior exposure to BASIC: as potential programmers they are mentally
mutilated beyond hope of regeneration. -- Edsger Dijkstra
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-03-30 11:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 19:30 [U-Boot] [RFC 0/7] Universal PHY Infrastructure Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 1/7] tsec: use IO accessories to access the register Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 2/7] tsec: arrange the code to avoid useless function declaration Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 3/7] Remove instances of phy_read/write Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 4/7] Create PHY Lib for U-Boot Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 5/7] Add mdio command for new PHY infrastructure Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 6/7] phylib: Add a bunch of PHY drivers from tsec Andy Fleming
2011-03-29 19:30 ` [U-Boot] [PATCH 7/7] tsec: Convert tsec to use PHY Lib Andy Fleming
2011-03-30 12:32 ` Detlev Zundel
2011-03-30 12:26 ` [U-Boot] [PATCH 6/7] phylib: Add a bunch of PHY drivers from tsec Detlev Zundel
2011-03-31 1:13 ` Andy Fleming
2011-03-30 11:55 ` [U-Boot] [PATCH 5/7] Add mdio command for new PHY infrastructure Detlev Zundel
2011-03-30 23:05 ` Andy Fleming
2011-03-30 23:18 ` Mike Frysinger
2011-03-30 11:47 ` [U-Boot] [PATCH 4/7] Create PHY Lib for U-Boot Detlev Zundel
2011-03-30 11:11 ` [U-Boot] [PATCH 3/7] Remove instances of phy_read/write Detlev Zundel
2011-03-30 11:07 ` Detlev Zundel [this message]
2011-03-31 8:13 ` [U-Boot] [PATCH 2/7] tsec: arrange the code to avoid useless function declaration Kumar Gala
2011-03-31 14:01 ` Fleming Andy-AFLEMING
2011-03-31 8:12 ` [U-Boot] [PATCH 1/7] tsec: use IO accessories to access the register Kumar Gala
2011-03-30 12:06 ` [U-Boot] [RFC 0/7] Universal PHY Infrastructure Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tyekn9xf.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox