[U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific

Stefan Roese
2010-09-16T13:47:00Z

Hi Detlev,

On Thursday 16 September 2010 15:00:05 Detlev Zundel wrote:
> > Please note that I plan to stay with this "asm/ppc4xx-gpio.h" name
> > instead of "asm/gpio.h", since there are many other PowerPC variants out
> > there.
>
> I have to admit that I don't like this.
>
> Hm, while you are doing something here, why not follow the Blackfin
> example which I like a lot and move towards the Linux gpio interface
> (see end of ./arch/blackfin/include/asm/gpio.h). It will be just lovely
> to only generically request a gpio in common driver code.
>
> Going down this route, code using gpios will only include "asm/gpio.h"
> and use the generic functions. Doesn't that sound like a worthwhile
> target? ;)

Sure. I'm all for this idea, all platforms implementing this common GPIO
framework. The current 4xx GPIO implementation out-dates the Linux framework,
since I added this quite some time ago. Perhaps I'll find some time in the
future to move to this common platform for PPC4xx as well. I won't complain if
somebody beats me at though. ;)

Back to the subject: This patch right now was simply meant as part of a header
cleanup patch, moving a 4xx specific header with stuff like this:

/* GPIO controller */
struct ppc4xx_gpio {
u32 or; /* Output Control */
u32 tcr; /* Tri-State Control */
...

to a "better" name. Even though the common gpio framework should be the "final
target", I think it makes sense to make this header name move right now.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de