From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Mon, 11 Jan 2010 16:48:55 +0100 Subject: [U-Boot] [PATCH 2/9] MX51: Add initial support for the Freescale MX51 In-Reply-To: <1263212760-27272-3-git-send-email-sbabic@denx.de> (Stefano Babic's message of "Mon, 11 Jan 2010 13:25:53 +0100") References: <1263212760-27272-1-git-send-email-sbabic@denx.de> <1263212760-27272-2-git-send-email-sbabic@denx.de> <1263212760-27272-3-git-send-email-sbabic@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, > The patch add initial support for the Freescale i.MX51 processor > (family arm cortex_a8). A small comment below. [...] > diff --git a/cpu/arm_cortexa8/mx51/iomux.c b/cpu/arm_cortexa8/mx51/iomux.c > new file mode 100644 > index 0000000..a42ec3a > --- /dev/null > +++ b/cpu/arm_cortexa8/mx51/iomux.c > @@ -0,0 +1,205 @@ > +/* > + * Copyright 2009 Freescale Semiconductor, Inc. All Rights Reserved. > + */ > + > +/* > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ This header is not good enough - it is not clear what actual version of the GPL the code is licensed under. Please replace this with a "standard" header. Cheers Detlev -- Emacs seems a more likely candidate to contain a mail system than the mail system to contain an Emacs, so this is the way it was done. -- Bernard S. Greenberg -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de