public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0
Date: Wed, 25 Mar 2009 10:40:36 +0100	[thread overview]
Message-ID: <m2tz5iq6sr.fsf@ohwell.denx.de> (raw)
In-Reply-To: <20090324223803.2CFC5832E406@gemini.denx.de> (Wolfgang Denk's message of "Tue, 24 Mar 2009 23:38:03 +0100")

Hi Wolfgang,

> Dear Heiko & Detlev,
>
> In message <49C91E04.2020801@denx.de> you wrote:
> ...
>> > +#define GPIO_BASE  (u_char *)0x30400000
>> >   
>> 
>> should be
>> 
>> #define GPIO_BASE  (u_char *)CONFIG_SYS_CS3_START
>
> or
> 	#define GPIO_BASE  ((u_char *)CONFIG_SYS_CS3_START)
> ?
>
>> > +#define SERIAL_PORT_BASE	(u_char *)0x80000000
>> >   
>> 
>> this should be
>> 
>> #define SERIAL_PORT_BASE	(u_char *)CONFIG_SYS_CS2_START
>
> or
> 	#define SERIAL_PORT_BASE	((u_char *)CONFIG_SYS_CS2_START)
> ? 

Yes, I agree.

Thanks
  Detlev

-- 
Ftpd never switches uid and euid, it uses setfsuid(2) instead. The
main reason is that uid switching has been exploited in several
breakins, but the sheer ugliness of uid switching counts too.
                                     -- pure-ftpd(8)
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2009-03-25  9:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 17:02 [U-Boot] [PATCH v1 0/7] Update for inka4x0 plus some new features Detlev Zundel
2009-03-24 17:02 ` [U-Boot] [PATCH] command.c: Expose the core of do_help as _do_help to the rest of u-boot Detlev Zundel
2009-03-24 17:02   ` [U-Boot] [PATCH] mpc5xxx: Add structure definition for several more register blocks Detlev Zundel
2009-03-24 17:02     ` [U-Boot] [PATCH] drivers/twserial: Add protocol driver for "three wire serial" interface Detlev Zundel
2009-03-24 17:02       ` [U-Boot] [PATCH] rtc: add support for 4543 RTC (manufactured by e.g. EPSON) Detlev Zundel
2009-03-24 17:02         ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0 Detlev Zundel
2009-03-24 17:02           ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis and RTC in configuration Detlev Zundel
2009-03-24 17:02             ` [U-Boot] [PATCH] inka4x0: Use proper accessor macros for memory mapped registers Detlev Zundel
2009-03-24 22:56             ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis and RTC in configuration Wolfgang Denk
2009-03-25  9:16               ` Detlev Zundel
2009-03-25  9:41                 ` Wolfgang Denk
2009-03-25 15:18                   ` Detlev Zundel
2009-03-24 23:47             ` Anatolij Gustschin
2009-03-24 17:53           ` [U-Boot] [PATCH] inka4x0: Add hardware diagnosis functions for inka4x0 Heiko Schocher
2009-03-24 22:38             ` Wolfgang Denk
2009-03-25  9:40               ` Detlev Zundel [this message]
2009-03-25  9:40             ` Detlev Zundel
2009-03-25 12:16               ` Heiko Schocher
2009-03-24 22:50           ` Wolfgang Denk
2009-03-24 23:08             ` Scott Wood
2009-03-25 15:07             ` Detlev Zundel
2009-03-25 19:07               ` Wolfgang Denk
2009-03-24 23:36           ` Anatolij Gustschin
2009-03-25  9:13             ` Detlev Zundel
2009-03-24 22:54       ` [U-Boot] [PATCH] drivers/twserial: Add protocol driver for "three wire serial" interface Wolfgang Denk
2009-03-25 15:49         ` Detlev Zundel
2009-03-27 20:04     ` [U-Boot] [PATCH] mpc5xxx: Add structure definition for several more register blocks Wolfgang Denk
2009-03-24 22:36 ` [U-Boot] [PATCH v1 0/7] Update for inka4x0 plus some new features Wolfgang Denk
2009-03-25 15:12   ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2tz5iq6sr.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox