From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/12] da850: print DDR frequency from u-boot
Date: Wed, 17 Aug 2011 17:48:06 +0200 [thread overview]
Message-ID: <m2vctwxcnd.fsf@ohwell.denx.de> (raw)
In-Reply-To: <4E4BE04E.8040701@denx.de> (Stefano Babic's message of "Wed, 17 Aug 2011 17:37:50 +0200")
Hi Stefano,
> On 08/17/2011 02:47 PM, Netagunte, Nagabhushana wrote:
>>> Maybe we should use this opportunity to align them? So what
>>> example should we follow? Hm, oldest code wins, so here we go:
>
> Never heard about this rule, but I agree it makes no sense to have
> differen commands.
You never heard about the principle of least surprise? Commands doing
the same thing should be called by the same name...
>>> [dzu at pollux u-boot-testing (master)]$ for f in
>>> arch/arm/cpu/arm1136/mx35/generic.c arch/arm/cpu/armv7/mx5/clock.c
>>> arch/powerpc/cpu/mpc512x/speed.c arch/powerpc/cpu/mpc83xx/speed.c ;
>>> do git describe --contains `git log --follow --pretty=format:%H $f
>>> | tail -1` ; done
>>> v2011.03-rc1~2^2~36
>>> v2010.03-rc1~35
>>> v1.3.0-rc4~69^2~1
>>> U-Boot-1_1_3~20^2~7
>>>
>>> So PowerPC wins ;) I.e. please use "clocks" as the command name,
>>> and I'd appreciate it if you send a patch changing the mx35 and mx5
>>> code.
>
> No luck here for i.MX ;-). I will send the patch to change the command
> name for i.MX.
Thanks in advance! I really hope that this command was never widely
used so we don't need to keep an deprecated alias for some time...
/me ducks and runs
Cheers
Detlev
--
There are two hard things in computer science: cache invalidation,
naming things, and off-by-one errors.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
prev parent reply other threads:[~2011-08-17 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 15:43 [U-Boot] [PATCH 00/12] feature additions and fixes for da850 nagabhushana.netagunte at ti.com
2011-08-02 15:43 ` [U-Boot] [PATCH 01/12] da850: indicate cache usage disable in config file nagabhushana.netagunte at ti.com
2011-08-02 16:06 ` Wolfgang Denk
2011-08-02 19:37 ` Laurence Withers
2011-08-09 13:44 ` Netagunte, Nagabhushana
2011-08-09 13:54 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 02/12] da8xx: add support for multiple PLL controllers nagabhushana.netagunte at ti.com
2011-08-02 15:43 ` [U-Boot] [PATCH 03/12] da850: add NOR boot mode support nagabhushana.netagunte at ti.com
2011-08-02 16:12 ` Wolfgang Denk
2011-08-09 14:03 ` Netagunte, Nagabhushana
2011-08-10 10:50 ` Detlev Zundel
2011-08-17 12:43 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 04/12] da850: modify the U-Boot prompt string nagabhushana.netagunte at ti.com
2011-08-02 15:43 ` [U-Boot] [PATCH 05/12] da850: add support to read mac address from spi flash nagabhushana.netagunte at ti.com
2011-08-02 16:20 ` Wolfgang Denk
2011-08-09 14:05 ` Netagunte, Nagabhushana
2011-08-02 16:23 ` Wolfgang Denk
2011-08-09 14:08 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 06/12] da850: add support to wake up DSP during board init nagabhushana.netagunte at ti.com
2011-08-02 16:25 ` Wolfgang Denk
2011-08-09 14:10 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 07/12] da850: add support for Spectrum Digital AM18xx EVM nagabhushana.netagunte at ti.com
2011-08-02 15:43 ` [U-Boot] [PATCH 08/12] da850: pass board revision info to kernel nagabhushana.netagunte at ti.com
2011-08-02 16:27 ` Wolfgang Denk
2011-08-09 13:52 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 09/12] da850: read MAC address from I2C EEPROM on AM18xx EVM nagabhushana.netagunte at ti.com
2011-08-02 16:30 ` Wolfgang Denk
2011-08-09 13:47 ` Netagunte, Nagabhushana
2011-09-15 10:50 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 10/12] da850: fix the channel number for EMAC teardown init nagabhushana.netagunte at ti.com
2011-08-02 15:43 ` [U-Boot] [PATCH 11/12] da850: modifications for Logic PD Rev.3 AM18xx EVM nagabhushana.netagunte at ti.com
2011-08-02 16:32 ` Wolfgang Denk
2011-08-09 13:45 ` Netagunte, Nagabhushana
2011-08-02 15:43 ` [U-Boot] [PATCH 12/12] da850: print DDR frequency from u-boot nagabhushana.netagunte at ti.com
2011-08-02 16:33 ` Wolfgang Denk
2011-08-09 13:40 ` Netagunte, Nagabhushana
2011-08-10 10:47 ` Detlev Zundel
2011-08-17 12:47 ` Netagunte, Nagabhushana
2011-08-17 15:37 ` Stefano Babic
2011-08-17 15:48 ` Detlev Zundel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vctwxcnd.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox